Add json tests, swap out orjson for standard json

#3

Author: dbanty

openapi_python_client/__init__.py

@@ -1,8 +1,8 @@
 """ Generate modern Python clients from OpenAPI """
+import json
 from pathlib import Path
 from typing import Any, Dict, Optional
 
-import orjson
 import requests
 from jinja2 import Environment, PackageLoader
 
@@ -18,14 +18,16 @@ def main(*, url: Optional[str], path: Optional[str]) -> None:
 
 def _get_json(*, url: Optional[str], path: Optional[str]) -> Dict[str, Any]:
     json_bytes: bytes
-    if url is not None:
+    if url is not None and path is not None:
+        raise ValueError("Provide URL or Path, not both.")
+    elif url is not None:
         response = requests.get(url)
         json_bytes = response.content
     elif path is not None:
         json_bytes = Path(path).read_bytes()
     else:
         raise ValueError("No URL or Path provided")
-    return orjson.loads(json_bytes)
+    return json.loads(json_bytes)
 
 
 def _build_project(*, openapi: OpenAPI) -> None:

poetry.lock

@@ -17,7 +17,6 @@ include = ["CHANGELOG.md", "openapi_python_client/py.typed"]
 [tool.poetry.dependencies]
 python = "==3.*,>=3.8.0"
 requests = "^2.22.0"
-orjson = "^2.4.0"
 jinja2 = "^2.11.1"
 stringcase = "^1.2.0"
 click = "^7.0"

pyproject.toml

@@ -1,3 +1,6 @@
+import pytest
+
+
 def test_main(mocker):
     data_dict = mocker.MagicMock()
     _get_json = mocker.patch("openapi_python_client._get_json", return_value=data_dict)
@@ -14,3 +17,61 @@ def test_main(mocker):
     _get_json.assert_called_once_with(url=url, path=path)
     from_dict.assert_called_once_with(data_dict)
     _build_project.assert_called_once_with(openapi=openapi)
+
+
+class TestGetJson:
+    def test__get_json_no_url_or_path(self, mocker):
+        get = mocker.patch("requests.get")
+        Path = mocker.patch("pathlib.Path")
+        loads = mocker.patch("json.loads")
+
+        from openapi_python_client import _get_json
+
+        with pytest.raises(ValueError):
+            _get_json(url=None, path=None)
+
+        get.assert_not_called()
+        Path.assert_not_called()
+        loads.assert_not_called()
+
+    def test__get_json_url_and_path(self, mocker):
+        get = mocker.patch("requests.get")
+        Path = mocker.patch("pathlib.Path")
+        loads = mocker.patch("json.loads")
+
+        from openapi_python_client import _get_json
+
+        with pytest.raises(ValueError):
+            _get_json(url=mocker.MagicMock(), path=mocker.MagicMock())
+
+        get.assert_not_called()
+        Path.assert_not_called()
+        loads.assert_not_called()
+
+    def test__get_json_url_no_path(self, mocker):
+        get = mocker.patch("requests.get")
+        Path = mocker.patch("pathlib.Path")
+        loads = mocker.patch("json.loads")
+
+        from openapi_python_client import _get_json
+
+        url = mocker.MagicMock()
+        _get_json(url=url, path=None)
+
+        get.assert_called_once_with(url)
+        Path.assert_not_called()
+        loads.assert_called_once_with(get().content)
+
+    def test__get_json_path_no_url(self, mocker):
+        get = mocker.patch("requests.get")
+        Path = mocker.patch("pathlib.Path")
+        loads = mocker.patch("json.loads")
+
+        from openapi_python_client import _get_json
+
+        path = mocker.MagicMock()
+        _get_json(url=None, path=path)
+
+        get.assert_not_called()
+        Path.assert_called_once_with(path)
+        loads.assert_called_once_with(Path().read_bytes())