Skip to content

Commit 5b8ea18

Browse files
committed
feat: improve install.sh UX with clearer prompts and correct tap syntax
- Add explicit password prompt warning for Xcode CLT installation - Change to 'brew install openbootdotdev/tap/openboot' (full tap path) - Remove redundant tap check since full path auto-taps if needed - Improve dry-run output to show actual command that will run - Use consistent ✓ checkmark for success messages User experience improvements: - Users now know upfront that Xcode CLT requires password - 'Press Enter to launch installer' gives users control - Clearer indication of what's happening during installation
1 parent fddb5d4 commit 5b8ea18

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

scripts/install.sh

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,22 @@ install_xcode_clt() {
1212
return 0
1313
fi
1414

15-
echo "Installing Xcode Command Line Tools..."
16-
echo "(A dialog may appear - please click 'Install')"
15+
echo ""
16+
echo "⚠️ ACTION REQUIRED"
17+
echo ""
18+
echo "Xcode Command Line Tools need to be installed."
19+
echo "A dialog will appear - please click 'Install' and enter your password."
20+
echo ""
21+
read -p "Press Enter to launch installer..." -r
1722
echo ""
1823

1924
xcode-select --install 2>/dev/null || true
2025

21-
echo "Waiting for Xcode Command Line Tools installation..."
26+
echo "Waiting for installation to complete..."
2227
until xcode-select -p &>/dev/null; do
2328
sleep 5
2429
done
25-
echo "Xcode Command Line Tools installed!"
30+
echo "Xcode Command Line Tools installed!"
2631
echo ""
2732
}
2833

@@ -116,9 +121,8 @@ main() {
116121
echo "Would perform:"
117122
echo " 1. Check/Install Xcode Command Line Tools"
118123
echo " 2. Check/Install Homebrew"
119-
echo " 3. Run: brew tap ${TAP_NAME}"
120-
echo " 4. Run: brew install ${BINARY_NAME}"
121-
echo " 5. Launch: ${BINARY_NAME}"
124+
echo " 3. Run: brew install ${TAP_NAME}/${BINARY_NAME}"
125+
echo " 4. Launch: ${BINARY_NAME}"
122126
echo ""
123127
echo "To actually install, run without OPENBOOT_DRY_RUN:"
124128
echo " curl -fsSL https://openboot.dev/install.sh | bash"
@@ -139,7 +143,7 @@ main() {
139143

140144
if [[ $REPLY =~ ^[Yy]$ ]]; then
141145
echo "Reinstalling OpenBoot..."
142-
brew reinstall openboot
146+
brew reinstall ${TAP_NAME}/openboot
143147
echo ""
144148
echo "✓ OpenBoot reinstalled!"
145149
else
@@ -149,11 +153,7 @@ main() {
149153
echo "Installing OpenBoot via Homebrew..."
150154
echo ""
151155

152-
if ! brew tap | grep -q "${TAP_NAME}"; then
153-
brew tap "${TAP_NAME}"
154-
fi
155-
156-
brew install openboot
156+
brew install ${TAP_NAME}/openboot
157157

158158
echo ""
159159
echo "✓ OpenBoot installed!"

0 commit comments

Comments
 (0)