Skip to content

Commit 1043f93

Browse files
committed
feat(identity): Add id field in update domain tool(#31)
- Add id field in update_domain tool - Tests are updated and passing - Resolve conlfict
2 parents 98e3428 + d7d60da commit 1043f93

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/openstack_mcp_server/tools/identity_tools.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from fastmcp import FastMCP
22

33
from .base import get_openstack_conn
4-
from .response.identity import Region, Domain
4+
from .response.identity import Domain, Region
55

66

77
class IdentityTools:
@@ -23,8 +23,11 @@ def register_tools(self, mcp: FastMCP):
2323
mcp.tool()(self.get_domains)
2424
mcp.tool()(self.get_domain)
2525
mcp.tool()(self.create_domain)
26+
<<<<<<< HEAD
2627
mcp.tool()(self.delete_domain)
2728
mcp.tool()(self.update_domain)
29+
=======
30+
>>>>>>> d7d60da163653af86da9ffa64fb394cbb1ea8c40
2831

2932
def get_regions(self) -> list[Region]:
3033
"""
@@ -186,4 +189,4 @@ def update_domain(self, id: str, name: str | None = None, description: str | Non
186189

187190
return Domain(id=updated_domain.id, name=updated_domain.name, description=updated_domain.description, is_enabled=updated_domain.is_enabled)
188191

189-
192+

tests/tools/test_identity_tools.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from openstack import exceptions
77

88
from openstack_mcp_server.tools.identity_tools import IdentityTools
9-
from openstack_mcp_server.tools.response.identity import Region, Domain
9+
from openstack_mcp_server.tools.response.identity import Domain, Region
1010

1111

1212
class TestIdentityTools:
@@ -611,4 +611,3 @@ def test_update_domain_with_empty_id(self, mock_get_openstack_conn_identity):
611611
# Verify mock calls
612612
mock_conn.identity.update_domain.assert_called_once_with(domain="")
613613

614-

0 commit comments

Comments
 (0)