Skip to content

Commit 1228a28

Browse files
committed
chore(identity): ruff format(#58)
1 parent 7340ef7 commit 1228a28

File tree

3 files changed

+31
-30
lines changed

3 files changed

+31
-30
lines changed

src/openstack_mcp_server/tools/identity_tools.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def register_tools(self, mcp: FastMCP):
2525
mcp.tool()(self.create_domain)
2626
mcp.tool()(self.delete_domain)
2727
mcp.tool()(self.update_domain)
28-
28+
2929
mcp.tool()(self.get_projects)
3030
mcp.tool()(self.get_project)
3131

@@ -231,7 +231,7 @@ def get_projects(self) -> list[Project]:
231231
:return: A list of Project objects representing the projects.
232232
"""
233233
conn = get_openstack_conn()
234-
234+
235235
project_list = []
236236
for project in conn.identity.projects():
237237
project_list.append(
@@ -246,7 +246,7 @@ def get_projects(self) -> list[Project]:
246246
)
247247

248248
return project_list
249-
249+
250250
def get_project(self, name: str) -> Project:
251251
"""
252252
Get a project.
@@ -257,7 +257,9 @@ def get_project(self, name: str) -> Project:
257257
"""
258258
conn = get_openstack_conn()
259259

260-
project = conn.identity.find_project(name_or_id=name, ignore_missing=False)
260+
project = conn.identity.find_project(
261+
name_or_id=name, ignore_missing=False
262+
)
261263

262264
return Project(
263265
id=project.id,
@@ -267,4 +269,3 @@ def get_project(self, name: str) -> Project:
267269
domain_id=project.domain_id,
268270
parent_id=project.parent_id,
269271
)
270-

src/openstack_mcp_server/tools/response/identity.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@ class Domain(BaseModel):
1414
description: str | None = None
1515
is_enabled: bool | None = None
1616

17+
1718
class Project(BaseModel):
1819
id: str
1920
name: str
2021
description: str | None = None
2122
is_enabled: bool | None = None
2223
domain_id: str | None = None
23-
parent_id: str | None = None
24+
parent_id: str | None = None

tests/tools/test_identity_tools.py

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
from openstack import exceptions
77

88
from openstack_mcp_server.tools.identity_tools import IdentityTools
9-
from openstack_mcp_server.tools.response.identity import Domain, Region, Project
9+
from openstack_mcp_server.tools.response.identity import (
10+
Domain,
11+
Region,
12+
Project,
13+
)
1014

1115

1216
class TestIdentityTools:
@@ -736,14 +740,17 @@ def test_get_projects_success(self, mock_get_openstack_conn_identity):
736740
mock_project2.is_enabled = False
737741
mock_project2.domain_id = "domain22222222222222222222222222"
738742
mock_project2.parent_id = "default"
739-
743+
740744
# Configure mock project.projects()
741-
mock_conn.identity.projects.return_value = [mock_project1, mock_project2]
742-
745+
mock_conn.identity.projects.return_value = [
746+
mock_project1,
747+
mock_project2,
748+
]
749+
743750
# Test get_projects()
744751
identity_tools = self.get_identity_tools()
745752
result = identity_tools.get_projects()
746-
753+
747754
# Verify results
748755
assert result == [
749756
Project(
@@ -763,29 +770,27 @@ def test_get_projects_success(self, mock_get_openstack_conn_identity):
763770
parent_id="default",
764771
),
765772
]
766-
773+
767774
# Verify mock calls
768775
mock_conn.identity.projects.assert_called_once()
769-
770-
771-
776+
772777
def test_get_projects_empty_list(self, mock_get_openstack_conn_identity):
773778
"""Test getting identity projects when there are no projects."""
774779
mock_conn = mock_get_openstack_conn_identity
775780

776781
# Empty project list
777782
mock_conn.identity.projects.return_value = []
778-
783+
779784
# Test get_projects()
780785
identity_tools = self.get_identity_tools()
781786
result = identity_tools.get_projects()
782-
787+
783788
# Verify results
784789
assert result == []
785-
790+
786791
# Verify mock calls
787792
mock_conn.identity.projects.assert_called_once()
788-
793+
789794
def test_get_project_success(self, mock_get_openstack_conn_identity):
790795
"""Test getting a identity project successfully."""
791796
mock_conn = mock_get_openstack_conn_identity
@@ -805,7 +810,7 @@ def test_get_project_success(self, mock_get_openstack_conn_identity):
805810
# Test get_project()
806811
identity_tools = self.get_identity_tools()
807812
result = identity_tools.get_project(name="ProjectOne")
808-
813+
809814
# Verify results
810815
assert result == Project(
811816
id="project1111111111111111111111111",
@@ -815,13 +820,13 @@ def test_get_project_success(self, mock_get_openstack_conn_identity):
815820
domain_id="domain1111111111111111111111111",
816821
parent_id="parentproject1111111111111111111",
817822
)
818-
823+
819824
# Verify mock calls
820825
mock_conn.identity.find_project.assert_called_once_with(
821826
name_or_id="ProjectOne",
822827
ignore_missing=False,
823828
)
824-
829+
825830
def test_get_project_not_found(self, mock_get_openstack_conn_identity):
826831
"""Test getting a identity project that does not exist."""
827832
mock_conn = mock_get_openstack_conn_identity
@@ -835,22 +840,16 @@ def test_get_project_not_found(self, mock_get_openstack_conn_identity):
835840

836841
# Test get_project()
837842
identity_tools = self.get_identity_tools()
838-
843+
839844
# Verify exception is raised
840845
with pytest.raises(
841846
exceptions.NotFoundException,
842847
match="Project 'ProjectOne' not found",
843848
):
844849
identity_tools.get_project(name="ProjectOne")
845-
850+
846851
# Verify mock calls
847852
mock_conn.identity.find_project.assert_called_once_with(
848853
name_or_id="ProjectOne",
849854
ignore_missing=False,
850855
)
851-
852-
853-
854-
855-
856-

0 commit comments

Comments
 (0)