fix(network): alignment subnet model field (#30)

Author: platanus-kr

src/openstack_mcp_server/config.py

@@ -4,7 +4,7 @@
 
 
 # Transport protocol
-MCP_TRANSPORT: str = os.environ.get("TRANSPORT", "stdio")
+MCP_TRANSPORT: str = os.environ.get("TRANSPORT", "streamable-http")
 
 # Openstack client settings
 MCP_CLOUD_NAME: str = os.environ.get("CLOUD_NAME", "openstack")

src/openstack_mcp_server/tools/network_tools.py

@@ -383,17 +383,19 @@ def _convert_to_subnet_model(self, openstack_subnet) -> Subnet:
         return Subnet(
             id=openstack_subnet.id,
             name=openstack_subnet.name,
-            status=openstack_subnet.status,
+            status=getattr(openstack_subnet, "status", None),
             description=openstack_subnet.description,
             project_id=openstack_subnet.project_id,
             network_id=openstack_subnet.network_id,
             cidr=openstack_subnet.cidr,
             ip_version=openstack_subnet.ip_version,
             gateway_ip=openstack_subnet.gateway_ip,
-            is_dhcp_enabled=openstack_subnet.enable_dhcp,
-            allocation_pools=openstack_subnet.allocation_pools,
-            dns_nameservers=openstack_subnet.dns_nameservers,
-            host_routes=openstack_subnet.host_routes,
+            is_dhcp_enabled=openstack_subnet.is_dhcp_enabled,
+            allocation_pools=getattr(
+                openstack_subnet, "allocation_pools", None
+            ),
+            dns_nameservers=getattr(openstack_subnet, "dns_nameservers", None),
+            host_routes=getattr(openstack_subnet, "host_routes", None),
         )
 
     def get_ports(

tests/tools/test_network_tools.py

@@ -815,6 +815,7 @@ def test_get_subnets_filters_and_has_gateway_true(
         subnet1.ip_version = 4
         subnet1.gateway_ip = "10.0.0.1"
         subnet1.enable_dhcp = True
+        subnet1.is_dhcp_enabled = True
         subnet1.allocation_pools = []
         subnet1.dns_nameservers = []
         subnet1.host_routes = []
@@ -830,6 +831,7 @@ def test_get_subnets_filters_and_has_gateway_true(
         subnet2.ip_version = 4
         subnet2.gateway_ip = None
         subnet2.enable_dhcp = False
+        subnet2.is_dhcp_enabled = False
         subnet2.allocation_pools = []
         subnet2.dns_nameservers = []
         subnet2.host_routes = []
@@ -888,6 +890,7 @@ def test_get_subnets_has_gateway_false(
         subnet1.ip_version = 4
         subnet1.gateway_ip = "10.0.0.1"
         subnet1.enable_dhcp = True
+        subnet1.is_dhcp_enabled = True
         subnet1.allocation_pools = []
         subnet1.dns_nameservers = []
         subnet1.host_routes = []
@@ -903,6 +906,7 @@ def test_get_subnets_has_gateway_false(
         subnet2.ip_version = 4
         subnet2.gateway_ip = None
         subnet2.enable_dhcp = False
+        subnet2.is_dhcp_enabled = False
         subnet2.allocation_pools = []
         subnet2.dns_nameservers = []
         subnet2.host_routes = []
@@ -935,6 +939,7 @@ def test_create_subnet_success(
         subnet.ip_version = 4
         subnet.gateway_ip = "10.0.0.1"
         subnet.enable_dhcp = True
+        subnet.is_dhcp_enabled = True
         subnet.allocation_pools = [{"start": "10.0.0.10", "end": "10.0.0.20"}]
         subnet.dns_nameservers = ["8.8.8.8"]
         subnet.host_routes = []
@@ -989,6 +994,7 @@ def test_get_subnet_detail_success(
         subnet.ip_version = 4
         subnet.gateway_ip = "10.0.0.1"
         subnet.enable_dhcp = True
+        subnet.is_dhcp_enabled = True
         subnet.allocation_pools = []
         subnet.dns_nameservers = []
         subnet.host_routes = []
@@ -1018,6 +1024,7 @@ def test_update_subnet_success(
         subnet.ip_version = 4
         subnet.gateway_ip = "10.0.0.254"
         subnet.enable_dhcp = False
+        subnet.is_dhcp_enabled = False
         subnet.allocation_pools = []
         subnet.dns_nameservers = []
         subnet.host_routes = []
@@ -1078,6 +1085,7 @@ def test_set_and_clear_subnet_gateway(
         updated.ip_version = 4
         updated.gateway_ip = "10.0.0.254"
         updated.enable_dhcp = True
+        updated.is_dhcp_enabled = True
         updated.allocation_pools = []
         updated.dns_nameservers = []
         updated.host_routes = []
@@ -1109,6 +1117,7 @@ def test_set_and_toggle_subnet_dhcp(
         updated.ip_version = 4
         updated.gateway_ip = "10.0.0.1"
         updated.enable_dhcp = True
+        updated.is_dhcp_enabled = True
         updated.allocation_pools = []
         updated.dns_nameservers = []
         updated.host_routes = []
@@ -1120,6 +1129,7 @@ def test_set_and_toggle_subnet_dhcp(
         assert res1.is_dhcp_enabled is True
 
         updated.enable_dhcp = False
+        updated.is_dhcp_enabled = False
         res2 = tools.update_subnet("subnet-1", is_dhcp_enabled=False)
         assert res2.is_dhcp_enabled is False