Skip to content

Commit 87fbf5f

Browse files
committed
fix(network): alignment port model field (#30)
1 parent 51e5060 commit 87fbf5f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/openstack_mcp_server/tools/network_tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ def _convert_to_port_model(self, openstack_port) -> Port:
603603
description=openstack_port.description,
604604
project_id=openstack_port.project_id,
605605
network_id=openstack_port.network_id,
606-
is_admin_state_up=openstack_port.admin_state_up,
606+
is_admin_state_up=openstack_port.is_admin_state_up,
607607
device_id=openstack_port.device_id,
608608
device_owner=openstack_port.device_owner,
609609
mac_address=openstack_port.mac_address,

tests/tools/test_network_tools.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ def test_get_ports_with_filters(self, mock_openstack_connect_network):
475475
port.project_id = "proj-1"
476476
port.network_id = "net-1"
477477
port.admin_state_up = True
478+
port.is_admin_state_up = True
478479
port.device_id = "device-1"
479480
port.device_owner = "compute:nova"
480481
port.mac_address = "fa:16:3e:00:00:01"
@@ -528,6 +529,7 @@ def test_create_port_success(self, mock_openstack_connect_network):
528529
port.project_id = "proj-1"
529530
port.network_id = "net-1"
530531
port.admin_state_up = True
532+
port.is_admin_state_up = True
531533
port.device_id = None
532534
port.device_owner = None
533535
port.mac_address = "fa:16:3e:00:00:02"
@@ -574,6 +576,7 @@ def test_get_port_detail_success(self, mock_openstack_connect_network):
574576
port.project_id = None
575577
port.network_id = "net-1"
576578
port.admin_state_up = True
579+
port.is_admin_state_up = True
577580
port.device_id = None
578581
port.device_owner = None
579582
port.mac_address = "fa:16:3e:00:00:03"
@@ -598,6 +601,7 @@ def test_update_port_success(self, mock_openstack_connect_network):
598601
port.project_id = None
599602
port.network_id = "net-1"
600603
port.admin_state_up = False
604+
port.is_admin_state_up = False
601605
port.device_id = "dev-2"
602606
port.device_owner = None
603607
port.mac_address = "fa:16:3e:00:00:04"
@@ -657,6 +661,7 @@ def test_add_port_fixed_ip(self, mock_openstack_connect_network):
657661
updated.project_id = None
658662
updated.network_id = "net-1"
659663
updated.admin_state_up = True
664+
updated.is_admin_state_up = True
660665
updated.device_id = None
661666
updated.device_owner = None
662667
updated.mac_address = "fa:16:3e:00:00:05"
@@ -691,6 +696,7 @@ def test_remove_port_fixed_ip(self, mock_openstack_connect_network):
691696
updated.project_id = None
692697
updated.network_id = "net-1"
693698
updated.admin_state_up = True
699+
updated.is_admin_state_up = True
694700
updated.device_id = None
695701
updated.device_owner = None
696702
updated.mac_address = "fa:16:3e:00:00:06"
@@ -729,6 +735,7 @@ def test_get_and_update_allowed_address_pairs(
729735
updated.project_id = None
730736
updated.network_id = "net-1"
731737
updated.admin_state_up = True
738+
updated.is_admin_state_up = True
732739
updated.device_id = None
733740
updated.device_owner = None
734741
updated.mac_address = "fa:16:3e:00:00:07"
@@ -769,7 +776,7 @@ def test_set_port_binding_and_admin_state(
769776
updated.description = None
770777
updated.project_id = None
771778
updated.network_id = "net-1"
772-
updated.admin_state_up = False
779+
updated.is_admin_state_up = False
773780
updated.device_id = None
774781
updated.device_owner = None
775782
updated.mac_address = "fa:16:3e:00:00:08"
@@ -790,9 +797,9 @@ def test_set_port_binding_and_admin_state(
790797
assert res_set.is_admin_state_up is False
791798

792799
current = Mock()
793-
current.admin_state_up = False
800+
current.is_admin_state_up = False
794801
mock_conn.network.get_port.return_value = current
795-
updated.admin_state_up = True
802+
updated.is_admin_state_up = True
796803
res_toggle = tools.update_port(
797804
"port-1", is_admin_state_up=not current.admin_state_up
798805
)

0 commit comments

Comments
 (0)