Skip to content

Commit b593684

Browse files
committed
fix(identity): Fix linter problem(#31)
1 parent 4d3aa1a commit b593684

File tree

3 files changed

+245
-107
lines changed

3 files changed

+245
-107
lines changed

src/openstack_mcp_server/tools/identity_tools.py

Lines changed: 47 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,13 @@ def register_tools(self, mcp: FastMCP):
1919
mcp.tool()(self.create_region)
2020
mcp.tool()(self.delete_region)
2121
mcp.tool()(self.update_region)
22-
22+
2323
mcp.tool()(self.get_domains)
2424
mcp.tool()(self.get_domain)
2525
mcp.tool()(self.create_domain)
2626
mcp.tool()(self.delete_domain)
2727
mcp.tool()(self.update_domain)
2828

29-
mcp.tool()(self.get_domains)
30-
mcp.tool()(self.get_domain)
31-
3229
def get_regions(self) -> list[Region]:
3330
"""
3431
Get the list of Identity regions.
@@ -121,7 +118,12 @@ def get_domains(self) -> list[Domain]:
121118
domain_list = []
122119
for domain in conn.identity.domains():
123120
domain_list.append(
124-
Domain(id=domain.id, name=domain.name, description=domain.description, is_enabled=domain.is_enabled),
121+
Domain(
122+
id=domain.id,
123+
name=domain.name,
124+
description=domain.description,
125+
is_enabled=domain.is_enabled,
126+
),
125127
)
126128
return domain_list
127129

@@ -134,12 +136,22 @@ def get_domain(self, name: str) -> Domain:
134136
:return: The Domain object.
135137
"""
136138
conn = get_openstack_conn()
137-
139+
138140
domain = conn.identity.find_domain(name_or_id=name)
139141

140-
return Domain(id=domain.id, name=domain.name, description=domain.description, is_enabled=domain.is_enabled)
141-
142-
def create_domain(self, name: str, description: str = "", is_enabled: bool = False) -> Domain:
142+
return Domain(
143+
id=domain.id,
144+
name=domain.name,
145+
description=domain.description,
146+
is_enabled=domain.is_enabled,
147+
)
148+
149+
def create_domain(
150+
self,
151+
name: str,
152+
description: str = "",
153+
is_enabled: bool = False,
154+
) -> Domain:
143155
"""
144156
Create a new domain.
145157
@@ -149,10 +161,19 @@ def create_domain(self, name: str, description: str = "", is_enabled: bool = Fal
149161
"""
150162
conn = get_openstack_conn()
151163

152-
domain = conn.identity.create_domain(name=name, description=description, enabled=is_enabled)
164+
domain = conn.identity.create_domain(
165+
name=name,
166+
description=description,
167+
enabled=is_enabled,
168+
)
169+
170+
return Domain(
171+
id=domain.id,
172+
name=domain.name,
173+
description=domain.description,
174+
is_enabled=domain.is_enabled,
175+
)
153176

154-
return Domain(id=domain.id, name=domain.name, description=domain.description, is_enabled=domain.is_enabled)
155-
156177
def delete_domain(self, name: str) -> None:
157178
"""
158179
Delete a domain.
@@ -165,8 +186,14 @@ def delete_domain(self, name: str) -> None:
165186
conn.identity.delete_domain(domain=domain, ignore_missing=False)
166187

167188
return None
168-
169-
def update_domain(self, id: str, name: str | None = None, description: str | None = None, is_enabled: bool | None = None) -> Domain:
189+
190+
def update_domain(
191+
self,
192+
id: str,
193+
name: str | None = None,
194+
description: str | None = None,
195+
is_enabled: bool | None = None,
196+
) -> Domain:
170197
"""
171198
Update a domain.
172199
@@ -187,4 +214,9 @@ def update_domain(self, id: str, name: str | None = None, description: str | Non
187214

188215
updated_domain = conn.identity.update_domain(domain=id, **args)
189216

190-
return Domain(id=updated_domain.id, name=updated_domain.name, description=updated_domain.description, is_enabled=updated_domain.is_enabled)
217+
return Domain(
218+
id=updated_domain.id,
219+
name=updated_domain.name,
220+
description=updated_domain.description,
221+
is_enabled=updated_domain.is_enabled,
222+
)

src/openstack_mcp_server/tools/response/identity.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ class Region(BaseModel):
77
id: str
88
description: str = ""
99

10+
1011
class Domain(BaseModel):
1112
id: str
1213
name: str

0 commit comments

Comments
 (0)