fix: apply suggestion (action

Author: choieastsea

src/openstack_mcp_server/tools/compute_tools.py

@@ -1,3 +1,4 @@
+from enum import Enum
 from typing import Any
 
 from fastmcp import FastMCP
@@ -10,6 +11,24 @@
 from .base import get_openstack_conn
 
 
+class ServerActionEnum(str, Enum):
+    """available actions without parameter for compute tools"""
+
+    PAUSE = "pause"
+    UNPAUSE = "unpause"
+    SUSPEND = "suspend"
+    RESUME = "resume"
+    LOCK = "lock"
+    UNLOCK = "unlock"
+    RESCUE = "rescue"
+    UNRESCUE = "unrescue"
+    START = "start"
+    STOP = "stop"
+    SHELVE = "shelve"
+    SHELVE_OFFLOAD = "shelve_offload"
+    UNSHELVE = "unshelve"
+
+
 class ComputeTools:
     """
     A class to encapsulate Compute-related tools and utilities.
@@ -104,7 +123,7 @@ def get_flavors(self) -> list[Flavor]:
             flavor_list.append(Flavor(**flavor))
         return flavor_list
 
-    def action_server(self, id: str, action: str) -> None:
+    def action_server(self, id: str, action: ServerActionEnum):
         """
         Perform an action on a Compute server.
 
@@ -125,25 +144,24 @@ def action_server(self, id: str, action: str) -> None:
                       - shelve_offload: Shelf-offloads, or removes, a shelved server
                       - unshelve: Unshelves, or restores, a shelved server
                       Only above actions are currently supported
-        :return: None
         :raises ValueError: If the action is not supported or invalid(ConflictException).
         """
         conn = get_openstack_conn()
 
         action_methods = {
-            "pause": conn.compute.pause_server,
-            "unpause": conn.compute.unpause_server,
-            "suspend": conn.compute.suspend_server,
-            "resume": conn.compute.resume_server,
-            "lock": conn.compute.lock_server,
-            "unlock": conn.compute.unlock_server,
-            "rescue": conn.compute.rescue_server,
-            "unrescue": conn.compute.unrescue_server,
-            "start": conn.compute.start_server,
-            "stop": conn.compute.stop_server,
-            "shelve": conn.compute.shelve_server,
-            "shelve_offload": conn.compute.shelve_offload_server,
-            "unshelve": conn.compute.unshelve_server,
+            ServerActionEnum.PAUSE: conn.compute.pause_server,
+            ServerActionEnum.UNPAUSE: conn.compute.unpause_server,
+            ServerActionEnum.SUSPEND: conn.compute.suspend_server,
+            ServerActionEnum.RESUME: conn.compute.resume_server,
+            ServerActionEnum.LOCK: conn.compute.lock_server,
+            ServerActionEnum.UNLOCK: conn.compute.unlock_server,
+            ServerActionEnum.RESCUE: conn.compute.rescue_server,
+            ServerActionEnum.UNRESCUE: conn.compute.unrescue_server,
+            ServerActionEnum.START: conn.compute.start_server,
+            ServerActionEnum.STOP: conn.compute.stop_server,
+            ServerActionEnum.SHELVE: conn.compute.shelve_server,
+            ServerActionEnum.SHELVE_OFFLOAD: conn.compute.shelve_offload_server,
+            ServerActionEnum.UNSHELVE: conn.compute.unshelve_server,
         }
 
         if action not in action_methods:

tests/tools/test_compute_tools.py

@@ -388,7 +388,7 @@ def test_action_server_success(self, mock_get_openstack_conn, action):
         # Verify the correct method was called with server ID
         action_method.assert_called_once_with(server_id)
 
-    def test_action_server_unsupported_action(self):
+    def test_action_server_unsupported_action(self, mock_get_openstack_conn):
         """Test action_server with unsupported action raises ValueError."""
         server_id = "test-server-id"
         unsupported_action = "invalid_action"