Skip to content

Commit d801519

Browse files
committed
feat: remove unnecessary ImageFactory class
1 parent 87b101a commit d801519

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tests/tools/test_image_tools.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
from openstack_mcp_server.tools.response.image import Image
88

99

10-
class ImageMockFactory:
10+
class TestImageTools:
11+
"""Test cases for ImageTools class."""
12+
1113
@staticmethod
12-
def image(**overrides):
14+
def image_factory(**overrides):
1315
defaults = {
1416
"id": str(uuid.uuid4()),
1517
"name": "test-image",
@@ -44,10 +46,6 @@ def image(**overrides):
4446

4547
return defaults
4648

47-
48-
class TestImageTools:
49-
"""Test cases for ImageTools class."""
50-
5149
def test_get_image_images_success(self, mock_get_openstack_conn_image):
5250
"""Test getting image images successfully."""
5351
mock_conn = mock_get_openstack_conn_image
@@ -130,7 +128,7 @@ def test_create_image_success_with_volume_id(
130128
"""Test creating an image from a volume ID."""
131129
volume_id = "6cf57d8d-00ca-43ff-ae6f-56912b69528a" # Example volume ID
132130

133-
mock_image = ImageMockFactory.image()
131+
mock_image = self.image_factory()
134132
mock_get_openstack_conn_image.block_storage.create_image.return_value = Mock(
135133
id=mock_image["id"],
136134
)
@@ -188,7 +186,7 @@ def test_create_image_success_with_import_options(
188186
allow_duplicates=False,
189187
)
190188

191-
mock_image = ImageMockFactory.image(**create_image_data.__dict__)
189+
mock_image = self.image_factory(**create_image_data.__dict__)
192190
mock_create_image = Mock(id=mock_image["id"])
193191

194192
mock_get_openstack_conn_image.image.create_image.return_value = (

0 commit comments

Comments
 (0)