Skip to content

Commit da6bdb5

Browse files
committed
feat(network): rename port to security group (#87)
1 parent db21adc commit da6bdb5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/openstack_mcp_server/tools/network_tools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def register_tools(self, mcp: FastMCP):
4545
mcp.tool()(self.get_port_allowed_address_pairs)
4646
mcp.tool()(self.set_port_binding)
4747
mcp.tool()(self.add_port_to_security_group)
48-
mcp.tool()(self.remove_security_group_from_port)
48+
mcp.tool()(self.remove_port_from_security_group)
4949
mcp.tool()(self.get_floating_ips)
5050
mcp.tool()(self.create_floating_ip)
5151
mcp.tool()(self.delete_floating_ip)
@@ -544,7 +544,7 @@ def add_port_to_security_group(
544544
)
545545
return self._convert_to_port_model(updated)
546546

547-
def remove_security_group_from_port(
547+
def remove_port_from_security_group(
548548
self,
549549
port_id: str,
550550
security_group_id: str,

tests/tools/test_network_tools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,15 +937,15 @@ def test_add_remove_security_group_on_port(
937937
updated_remove.security_group_ids = ["sg-1", "sg-2"]
938938
mock_conn.network.update_port.return_value = updated_remove
939939

940-
res_remove = tools.remove_security_group_from_port("port-1", "sg-9")
940+
res_remove = tools.remove_port_from_security_group("port-1", "sg-9")
941941
assert isinstance(res_remove, Port)
942942
mock_conn.network.update_port.assert_called_with(
943943
"port-1", security_groups=["sg-1", "sg-2"]
944944
)
945945

946946
# idempotent remove when sg not present
947947
mock_conn.network.get_port.return_value = updated_remove
948-
res_remove_again = tools.remove_security_group_from_port(
948+
res_remove_again = tools.remove_port_from_security_group(
949949
"port-1", "sg-9"
950950
)
951951
assert isinstance(res_remove_again, Port)

0 commit comments

Comments
 (0)