From 12983f32aa4e68092ac04b3a43297e519bf151c3 Mon Sep 17 00:00:00 2001 From: platanus-kr Date: Wed, 20 Aug 2025 20:52:29 +0900 Subject: [PATCH 1/2] fix(network): alignment network model field (#55) --- src/openstack_mcp_server/tools/network_tools.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openstack_mcp_server/tools/network_tools.py b/src/openstack_mcp_server/tools/network_tools.py index d4e8144..f873fad 100644 --- a/src/openstack_mcp_server/tools/network_tools.py +++ b/src/openstack_mcp_server/tools/network_tools.py @@ -197,8 +197,8 @@ def _convert_to_network_model(self, openstack_network) -> Network: name=openstack_network.name or "", status=openstack_network.status or "", description=openstack_network.description or None, - is_admin_state_up=openstack_network.admin_state_up or False, - is_shared=openstack_network.shared or False, + is_admin_state_up=openstack_network.is_admin_state_up or False, + is_shared=openstack_network.is_shared or False, mtu=openstack_network.mtu or None, provider_network_type=openstack_network.provider_network_type or None, From e33179fae38bc84164706d5736b6954d1774a6c7 Mon Sep 17 00:00:00 2001 From: platanus-kr Date: Wed, 20 Aug 2025 20:59:32 +0900 Subject: [PATCH 2/2] fix(network): test pass (#55) --- tests/tools/test_network_tools.py | 44 +++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/tests/tools/test_network_tools.py b/tests/tools/test_network_tools.py index 1604cae..c659a17 100644 --- a/tests/tools/test_network_tools.py +++ b/tests/tools/test_network_tools.py @@ -25,8 +25,8 @@ def test_get_networks_success( mock_network1.name = "private-network" mock_network1.status = "ACTIVE" mock_network1.description = "Private network for project" - mock_network1.admin_state_up = True - mock_network1.shared = False + mock_network1.is_admin_state_up = True + mock_network1.is_shared = False mock_network1.mtu = 1500 mock_network1.provider_network_type = "vxlan" mock_network1.provider_physical_network = None @@ -38,8 +38,8 @@ def test_get_networks_success( mock_network2.name = "public-network" mock_network2.status = "ACTIVE" mock_network2.description = "Public shared network" - mock_network2.admin_state_up = True - mock_network2.shared = True + mock_network2.is_admin_state_up = True + mock_network2.is_shared = True mock_network2.mtu = 1450 mock_network2.provider_network_type = "flat" mock_network2.provider_physical_network = "physnet1" @@ -113,8 +113,8 @@ def test_get_networks_with_status_filter( mock_network1.name = "active-network" mock_network1.status = "ACTIVE" mock_network1.description = None - mock_network1.admin_state_up = True - mock_network1.shared = False + mock_network1.is_admin_state_up = True + mock_network1.is_shared = False mock_network1.mtu = None mock_network1.provider_network_type = None mock_network1.provider_physical_network = None @@ -126,8 +126,8 @@ def test_get_networks_with_status_filter( mock_network2.name = "down-network" mock_network2.status = "DOWN" mock_network2.description = None - mock_network2.admin_state_up = False - mock_network2.shared = False + mock_network2.is_admin_state_up = False + mock_network2.is_shared = False mock_network2.mtu = None mock_network2.provider_network_type = None mock_network2.provider_physical_network = None @@ -160,8 +160,8 @@ def test_get_networks_shared_only( mock_network1.name = "private-network" mock_network1.status = "ACTIVE" mock_network1.description = None - mock_network1.admin_state_up = True - mock_network1.shared = False + mock_network1.is_admin_state_up = True + mock_network1.is_shared = False mock_network1.mtu = None mock_network1.provider_network_type = None mock_network1.provider_physical_network = None @@ -173,8 +173,8 @@ def test_get_networks_shared_only( mock_network2.name = "shared-network" mock_network2.status = "ACTIVE" mock_network2.description = None - mock_network2.admin_state_up = True - mock_network2.shared = True + mock_network2.is_admin_state_up = True + mock_network2.is_shared = True mock_network2.mtu = None mock_network2.provider_network_type = None mock_network2.provider_physical_network = None @@ -205,8 +205,8 @@ def test_create_network_success(self, mock_openstack_connect_network): mock_network.name = "new-network" mock_network.status = "ACTIVE" mock_network.description = "A new network" - mock_network.admin_state_up = True - mock_network.shared = False + mock_network.is_admin_state_up = True + mock_network.is_shared = False mock_network.mtu = 1500 mock_network.provider_network_type = "vxlan" mock_network.provider_physical_network = None @@ -260,8 +260,8 @@ def test_create_network_minimal_args(self, mock_openstack_connect_network): mock_network.name = "minimal-network" mock_network.status = "ACTIVE" mock_network.description = None - mock_network.admin_state_up = True - mock_network.shared = False + mock_network.is_admin_state_up = True + mock_network.is_shared = False mock_network.mtu = None mock_network.provider_network_type = None mock_network.provider_physical_network = None @@ -307,8 +307,8 @@ def test_get_network_detail_success(self, mock_openstack_connect_network): mock_network.name = "detail-network" mock_network.status = "ACTIVE" mock_network.description = "Network for detail testing" - mock_network.admin_state_up = True - mock_network.shared = True + mock_network.is_admin_state_up = True + mock_network.is_shared = True mock_network.mtu = 1500 mock_network.provider_network_type = "vlan" mock_network.provider_physical_network = "physnet1" @@ -364,8 +364,8 @@ def test_update_network_success(self, mock_openstack_connect_network): mock_network.name = "updated-network" mock_network.status = "ACTIVE" mock_network.description = "Updated description" - mock_network.admin_state_up = False - mock_network.shared = True + mock_network.is_admin_state_up = False + mock_network.is_shared = True mock_network.mtu = 1400 mock_network.provider_network_type = "vxlan" mock_network.provider_physical_network = None @@ -422,8 +422,8 @@ def test_update_network_partial_update( mock_network.name = "new-name" mock_network.status = "ACTIVE" mock_network.description = "old description" - mock_network.admin_state_up = True - mock_network.shared = False + mock_network.is_admin_state_up = True + mock_network.is_shared = False mock_network.mtu = None mock_network.provider_network_type = None mock_network.provider_physical_network = None