From ca95c9f84724bddfc58f3c68e90808cdf61b472d Mon Sep 17 00:00:00 2001 From: S0okJu Date: Fri, 24 Oct 2025 11:19:48 +0900 Subject: [PATCH] bug(cinder): Delete is_bootable attribute(#93) --- src/openstack_mcp_server/tools/block_storage_tools.py | 3 --- tests/tools/test_block_storage_tools.py | 5 ----- 2 files changed, 8 deletions(-) diff --git a/src/openstack_mcp_server/tools/block_storage_tools.py b/src/openstack_mcp_server/tools/block_storage_tools.py index 5c558bd..535778d 100644 --- a/src/openstack_mcp_server/tools/block_storage_tools.py +++ b/src/openstack_mcp_server/tools/block_storage_tools.py @@ -110,7 +110,6 @@ def create_volume( description: str | None = None, volume_type: str | None = None, availability_zone: str | None = None, - bootable: bool | None = None, image: str | None = None, ) -> Volume: """ @@ -121,7 +120,6 @@ def create_volume( :param description: Optional description for the volume :param volume_type: Optional volume type :param availability_zone: Optional availability zone - :param bootable: Optional flag to make the volume bootable :param image: Optional Image name, ID or object from which to create :return: The created Volume object """ @@ -141,7 +139,6 @@ def create_volume( volume = conn.block_storage.create_volume( size=size, image=image, - bootable=bootable, **volume_kwargs, ) diff --git a/tests/tools/test_block_storage_tools.py b/tests/tools/test_block_storage_tools.py index 09b57e0..b236dc0 100644 --- a/tests/tools/test_block_storage_tools.py +++ b/tests/tools/test_block_storage_tools.py @@ -395,7 +395,6 @@ def test_create_volume_success( mock_conn.block_storage.create_volume.assert_called_once_with( size=10, image=None, - bootable=None, name="new-volume", description="Test volume", volume_type="ssd", @@ -435,7 +434,6 @@ def test_create_volume_minimal_params( mock_conn.block_storage.create_volume.assert_called_once_with( size=5, image=None, - bootable=None, name="minimal-volume", ) @@ -468,7 +466,6 @@ def test_create_volume_with_image_and_bootable( "Bootable volume from image", "ssd", "nova", - True, "ubuntu-20.04", ) @@ -476,12 +473,10 @@ def test_create_volume_with_image_and_bootable( assert result.name == "bootable-volume" assert result.id == "vol-bootable" assert result.size == 20 - assert result.is_bootable mock_conn.block_storage.create_volume.assert_called_once_with( size=20, image="ubuntu-20.04", - bootable=True, name="bootable-volume", description="Bootable volume from image", volume_type="ssd",