Ensure that we set Deprecation False

Author: camilamacedo86

api/v1/clusterextension_types.go

@@ -500,13 +500,12 @@ type ClusterExtensionStatus struct {
 	// When Progressing is True and Reason is RollingOut, the ClusterExtension has one or more ClusterExtensionRevisions in active roll out.
 	// </opcon:experimental:description>
 	//
-	// When the ClusterExtension is sourced from a catalog, it may surface deprecation conditions based on catalog metadata.
-	// These are indications from a package owner to guide users away from a particular package, channel, or bundle.
-	// Deprecation conditions are only present when there's something to report - absence means "not deprecated".
-	//   - BundleDeprecated is set to True if the installed bundle is marked as deprecated in the catalog, or Unknown if no bundle is installed yet.
-	//   - ChannelDeprecated is set to True if any requested channel is marked as deprecated in the catalog, or Unknown if the channel is not found.
-	//   - PackageDeprecated is set to True if the requested package is marked as deprecated in the catalog, or Unknown if the package is not found.
-	//   - Deprecated is a rollup condition that is present only when at least one deprecation exists (True) or when catalog information is unavailable (Unknown).
+	// When the ClusterExtension is sourced from a catalog, it surfaces deprecation conditions based on catalog metadata.
+	// These are indications from a package owner to guide users away from a particular package, channel, or bundle:
+	//   - BundleDeprecated is True if the installed bundle is marked deprecated, False if not deprecated, or Unknown if no bundle is installed yet or if catalog data is unavailable.
+	//   - ChannelDeprecated is True if any requested channel is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+	//   - PackageDeprecated is True if the requested package is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+	//   - Deprecated is a rollup condition that is True when any deprecation exists, False when none exist, or Unknown when catalog data is unavailable.
 	//
 	// +listType=map
 	// +listMapKey=type

api/v1/common_types.go

@@ -30,6 +30,7 @@ const (
 
 	// Deprecation reasons
 	ReasonDeprecated               = "Deprecated"
+	ReasonNotDeprecated            = "NotDeprecated"
 	ReasonDeprecationStatusUnknown = "DeprecationStatusUnknown"
 
 	// Common reasons

docs/api-reference/olmv1-api-reference.md

@@ -360,7 +360,7 @@ _Appears in:_
 
 | Field | Description | Default | Validation |
 | --- | --- | --- | --- |
-| `conditions` _[Condition](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#condition-v1-meta) array_ | conditions represents the current state of the ClusterExtension.<br />The set of condition types which apply to all spec.source variations are Installed and Progressing.<br />The Installed condition represents whether the bundle has been installed for this ClusterExtension:<br />  - When Installed is True and the Reason is Succeeded, the bundle has been successfully installed.<br />  - When Installed is False and the Reason is Failed, the bundle has failed to install.<br />The Progressing condition represents whether or not the ClusterExtension is advancing towards a new state.<br />When Progressing is True and the Reason is Succeeded, the ClusterExtension is making progress towards a new state.<br />When Progressing is True and the Reason is Retrying, the ClusterExtension has encountered an error that could be resolved on subsequent reconciliation attempts.<br />When Progressing is False and the Reason is Blocked, the ClusterExtension has encountered an error that requires manual intervention for recovery.<br /><opcon:experimental:description><br />When Progressing is True and Reason is RollingOut, the ClusterExtension has one or more ClusterExtensionRevisions in active roll out.<br /></opcon:experimental:description><br />When the ClusterExtension is sourced from a catalog, it may surface deprecation conditions based on catalog metadata.<br />These are indications from a package owner to guide users away from a particular package, channel, or bundle.<br />Deprecation conditions are only present when there's something to report - absence means "not deprecated".<br />  - BundleDeprecated is set to True if the installed bundle is marked as deprecated in the catalog, or Unknown if no bundle is installed yet.<br />  - ChannelDeprecated is set to True if any requested channel is marked as deprecated in the catalog, or Unknown if the channel is not found.<br />  - PackageDeprecated is set to True if the requested package is marked as deprecated in the catalog, or Unknown if the package is not found.<br />  - Deprecated is a rollup condition that is present only when at least one deprecation exists (True) or when catalog information is unavailable (Unknown). |  |  |
+| `conditions` _[Condition](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#condition-v1-meta) array_ | conditions represents the current state of the ClusterExtension.<br />The set of condition types which apply to all spec.source variations are Installed and Progressing.<br />The Installed condition represents whether the bundle has been installed for this ClusterExtension:<br />  - When Installed is True and the Reason is Succeeded, the bundle has been successfully installed.<br />  - When Installed is False and the Reason is Failed, the bundle has failed to install.<br />The Progressing condition represents whether or not the ClusterExtension is advancing towards a new state.<br />When Progressing is True and the Reason is Succeeded, the ClusterExtension is making progress towards a new state.<br />When Progressing is True and the Reason is Retrying, the ClusterExtension has encountered an error that could be resolved on subsequent reconciliation attempts.<br />When Progressing is False and the Reason is Blocked, the ClusterExtension has encountered an error that requires manual intervention for recovery.<br /><opcon:experimental:description><br />When Progressing is True and Reason is RollingOut, the ClusterExtension has one or more ClusterExtensionRevisions in active roll out.<br /></opcon:experimental:description><br />When the ClusterExtension is sourced from a catalog, it surfaces deprecation conditions based on catalog metadata.<br />These are indications from a package owner to guide users away from a particular package, channel, or bundle:<br />  - BundleDeprecated is True if the installed bundle is marked deprecated, False if not deprecated, or Unknown if no bundle is installed yet or if catalog data is unavailable.<br />  - ChannelDeprecated is True if any requested channel is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.<br />  - PackageDeprecated is True if the requested package is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.<br />  - Deprecated is a rollup condition that is True when any deprecation exists, False when none exist, or Unknown when catalog data is unavailable. |  |  |
 | `install` _[ClusterExtensionInstallStatus](#clusterextensioninstallstatus)_ | install is a representation of the current installation status for this ClusterExtension. |  |  |
 | `activeRevisions` _[RevisionStatus](#revisionstatus) array_ | activeRevisions holds a list of currently active (non-archived) ClusterExtensionRevisions,<br />including both installed and rolling out revisions.<br /><opcon:experimental> |  |  |
 

helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterextensions.yaml

@@ -601,13 +601,12 @@ spec:
 
                   When Progressing is True and Reason is RollingOut, the ClusterExtension has one or more ClusterExtensionRevisions in active roll out.
 
-                  When the ClusterExtension is sourced from a catalog, it may surface deprecation conditions based on catalog metadata.
-                  These are indications from a package owner to guide users away from a particular package, channel, or bundle.
-                  Deprecation conditions are only present when there's something to report - absence means "not deprecated".
-                    - BundleDeprecated is set to True if the installed bundle is marked as deprecated in the catalog, or Unknown if no bundle is installed yet.
-                    - ChannelDeprecated is set to True if any requested channel is marked as deprecated in the catalog, or Unknown if the channel is not found.
-                    - PackageDeprecated is set to True if the requested package is marked as deprecated in the catalog, or Unknown if the package is not found.
-                    - Deprecated is a rollup condition that is present only when at least one deprecation exists (True) or when catalog information is unavailable (Unknown).
+                  When the ClusterExtension is sourced from a catalog, it surfaces deprecation conditions based on catalog metadata.
+                  These are indications from a package owner to guide users away from a particular package, channel, or bundle:
+                    - BundleDeprecated is True if the installed bundle is marked deprecated, False if not deprecated, or Unknown if no bundle is installed yet or if catalog data is unavailable.
+                    - ChannelDeprecated is True if any requested channel is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+                    - PackageDeprecated is True if the requested package is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+                    - Deprecated is a rollup condition that is True when any deprecation exists, False when none exist, or Unknown when catalog data is unavailable.
                 items:
                   description: Condition contains details for one aspect of the current
                     state of this API Resource.

helm/olmv1/base/operator-controller/crd/standard/olm.operatorframework.io_clusterextensions.yaml

@@ -507,13 +507,12 @@ spec:
                   When Progressing is True and the Reason is Retrying, the ClusterExtension has encountered an error that could be resolved on subsequent reconciliation attempts.
                   When Progressing is False and the Reason is Blocked, the ClusterExtension has encountered an error that requires manual intervention for recovery.
 
-                  When the ClusterExtension is sourced from a catalog, it may surface deprecation conditions based on catalog metadata.
-                  These are indications from a package owner to guide users away from a particular package, channel, or bundle.
-                  Deprecation conditions are only present when there's something to report - absence means "not deprecated".
-                    - BundleDeprecated is set to True if the installed bundle is marked as deprecated in the catalog, or Unknown if no bundle is installed yet.
-                    - ChannelDeprecated is set to True if any requested channel is marked as deprecated in the catalog, or Unknown if the channel is not found.
-                    - PackageDeprecated is set to True if the requested package is marked as deprecated in the catalog, or Unknown if the package is not found.
-                    - Deprecated is a rollup condition that is present only when at least one deprecation exists (True) or when catalog information is unavailable (Unknown).
+                  When the ClusterExtension is sourced from a catalog, it surfaces deprecation conditions based on catalog metadata.
+                  These are indications from a package owner to guide users away from a particular package, channel, or bundle:
+                    - BundleDeprecated is True if the installed bundle is marked deprecated, False if not deprecated, or Unknown if no bundle is installed yet or if catalog data is unavailable.
+                    - ChannelDeprecated is True if any requested channel is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+                    - PackageDeprecated is True if the requested package is marked deprecated, False if not deprecated, or Unknown if catalog data is unavailable.
+                    - Deprecated is a rollup condition that is True when any deprecation exists, False when none exist, or Unknown when catalog data is unavailable.
                 items:
                   description: Condition contains details for one aspect of the current
                     state of this API Resource.

internal/operator-controller/conditionsets/conditionsets.go

@@ -36,6 +36,7 @@ var ConditionTypes = []string{
 var ConditionReasons = []string{
 	ocv1.ReasonSucceeded,
 	ocv1.ReasonDeprecated,
+	ocv1.ReasonNotDeprecated,
 	ocv1.ReasonDeprecationStatusUnknown,
 	ocv1.ReasonFailed,
 	ocv1.ReasonBlocked,

internal/operator-controller/controllers/clusterextension_controller.go

@@ -196,11 +196,11 @@ func ensureFailureConditionsWithReason(ext *ocv1.ClusterExtension, reason v1alph
 
 // SetDeprecationStatus updates deprecation conditions based on catalog metadata.
 //
-// Behavior:
-//   - IS deprecated → condition True with Reason: Deprecated
-//   - NOT deprecated → condition absent (clean YAML)
-//   - Can't check (no catalog) → condition Unknown with Reason: DeprecationStatusUnknown
-//   - No bundle installed → BundleDeprecated Unknown with Reason: Absent
+// Behavior (following Kubernetes API conventions - conditions always present):
+//   - IS deprecated -> condition True with Reason: Deprecated
+//   - NOT deprecated -> condition False with Reason: NotDeprecated
+//   - Can't check (no catalog) -> condition Unknown with Reason: DeprecationStatusUnknown
+//   - No bundle installed -> BundleDeprecated Unknown with Reason: Absent
 //
 // This keeps deprecation conditions focused on catalog data. Install/validation errors
 // never appear here - they belong in Progressing/Installed conditions.
@@ -210,11 +210,12 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 	channelMessages := collectDeprecationMessages(info.ChannelEntries)
 	bundleMessages := collectDeprecationMessages(info.BundleEntries)
 
-	// Strategy: Only remove conditions when we're NOT going to re-add them.
-	// If we're setting a condition, call SetStatusCondition directly - it preserves
-	// lastTransitionTime when status/reason/message haven't changed, preventing
-	// infinite reconciliation loops.
-	// Absence of a deprecation condition means "not deprecated" - keeps output clean.
+	// Strategy: Always set deprecation conditions (following Kubernetes API conventions).
+	// SetStatusCondition preserves lastTransitionTime when status/reason/message haven't changed,
+	// preventing infinite reconciliation loops.
+	// - True = deprecated
+	// - False = not deprecated (verified via catalog)
+	// - Unknown = cannot verify (no catalog data or no bundle installed)
 
 	if !hasCatalogData {
 		// When catalog is unavailable, set all to Unknown.
@@ -256,8 +257,7 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 		return
 	}
 
-	// Handle catalog data available: set conditions to True when deprecated,
-	// or remove them when not deprecated (absence = not deprecated).
+	// Handle catalog data available: set conditions to True when deprecated, False when not.
 	messages := slices.Concat(packageMessages, channelMessages, bundleMessages)
 	if len(messages) > 0 {
 		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
@@ -268,8 +268,13 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 			ObservedGeneration: ext.GetGeneration(),
 		})
 	} else {
-		// Only remove if we're not setting it - prevents unnecessary lastTransitionTime updates
-		apimeta.RemoveStatusCondition(&ext.Status.Conditions, ocv1.TypeDeprecated)
+		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
+			Type:               ocv1.TypeDeprecated,
+			Status:             metav1.ConditionFalse,
+			Reason:             ocv1.ReasonNotDeprecated,
+			Message:            "not deprecated",
+			ObservedGeneration: ext.GetGeneration(),
+		})
 	}
 
 	if len(packageMessages) > 0 {
@@ -281,7 +286,13 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 			ObservedGeneration: ext.GetGeneration(),
 		})
 	} else {
-		apimeta.RemoveStatusCondition(&ext.Status.Conditions, ocv1.TypePackageDeprecated)
+		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
+			Type:               ocv1.TypePackageDeprecated,
+			Status:             metav1.ConditionFalse,
+			Reason:             ocv1.ReasonNotDeprecated,
+			Message:            "package not deprecated",
+			ObservedGeneration: ext.GetGeneration(),
+		})
 	}
 
 	if len(channelMessages) > 0 {
@@ -293,10 +304,16 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 			ObservedGeneration: ext.GetGeneration(),
 		})
 	} else {
-		apimeta.RemoveStatusCondition(&ext.Status.Conditions, ocv1.TypeChannelDeprecated)
+		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
+			Type:               ocv1.TypeChannelDeprecated,
+			Status:             metav1.ConditionFalse,
+			Reason:             ocv1.ReasonNotDeprecated,
+			Message:            "channel not deprecated",
+			ObservedGeneration: ext.GetGeneration(),
+		})
 	}
 
-	// BundleDeprecated: Unknown when no bundle installed, True when deprecated, absent otherwise
+	// BundleDeprecated: Unknown when no bundle installed, True when deprecated, False when not
 	if info.BundleStatus == metav1.ConditionUnknown {
 		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
 			Type:               ocv1.TypeBundleDeprecated,
@@ -314,7 +331,13 @@ func SetDeprecationStatus(ext *ocv1.ClusterExtension, installedBundleName string
 			ObservedGeneration: ext.GetGeneration(),
 		})
 	} else {
-		apimeta.RemoveStatusCondition(&ext.Status.Conditions, ocv1.TypeBundleDeprecated)
+		SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
+			Type:               ocv1.TypeBundleDeprecated,
+			Status:             metav1.ConditionFalse,
+			Reason:             ocv1.ReasonNotDeprecated,
+			Message:            "bundle not deprecated",
+			ObservedGeneration: ext.GetGeneration(),
+		})
 	}
 }