fix(e2e): use ifnotpresent for all test images

Author: ecordell

test/e2e/csv_e2e_test.go

@@ -136,6 +136,7 @@ func newNginxDeployment(name string) appsv1.DeploymentSpec {
 								ContainerPort: 80,
 							},
 						},
+						ImagePullPolicy: v1.PullIfNotPresent,
 					},
 				},
 			},
@@ -178,6 +179,7 @@ func newMockExtServerDeployment(name, mockGroupVersion string, mockKinds []strin
 								ContainerPort: 5443,
 							},
 						},
+						ImagePullPolicy: v1.PullIfNotPresent,
 					},
 				},
 			},

test/e2e/installplan_e2e_test.go

@@ -93,9 +93,10 @@ func newNginxInstallStrategy(name string, permissions []install.StrategyDeployme
 						},
 						Spec: corev1.PodSpec{Containers: []corev1.Container{
 							{
-								Name:  genName("nginx"),
-								Image: "bitnami/nginx:latest",
-								Ports: []corev1.ContainerPort{{ContainerPort: 80}},
+								Name:            genName("nginx"),
+								Image:           "bitnami/nginx:latest",
+								Ports:           []corev1.ContainerPort{{ContainerPort: 80}},
+								ImagePullPolicy: corev1.PullIfNotPresent,
 							},
 						}},
 					},

test/e2e/subscription_e2e_test.go

@@ -205,9 +205,10 @@ var (
 						},
 						Spec: corev1.PodSpec{Containers: []corev1.Container{
 							{
-								Name:  genName("nginx"),
-								Image: "bitnami/nginx:latest",
-								Ports: []corev1.ContainerPort{{ContainerPort: 80}},
+								Name:            genName("nginx"),
+								Image:           "bitnami/nginx:latest",
+								Ports:           []corev1.ContainerPort{{ContainerPort: 80}},
+								ImagePullPolicy: corev1.PullIfNotPresent,
 							},
 						}},
 					},