Helm upgrade to v3.11.1 for CVE-2023-25165 (#2933)

* Update Helm to v3.11.1

Updatate go.mod, go.sum, and vendor directory.

Signed-off-by: Todd Short <todd.short@me.com>

* Run go fmt

Plus some manual edits.

Signed-off-by: Todd Short <todd.short@me.com>

* Update from make verify

Signed-off-by: Todd Short <todd.short@me.com>

* Fix golangci-lint issues

Signed-off-by: Todd Short <todd.short@me.com>

* Client updates due to controller-runtime

Status is now updated using SubResource methods and options

Signed-off-by: Todd Short <todd.short@me.com>

---------

Signed-off-by: Todd Short <todd.short@me.com>

Author: tmshort

go.mod

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

go.sum

@@ -175,7 +175,7 @@ func (i *StrategyDeploymentInstaller) deploymentForSpec(name string, spec appsv1
 	// By default, each deployment created by OLM could spawn up to 10 replicaSets.
 	// By setting the deployments revisionHistoryLimit to 1, OLM will only create up
 	// to 2 ReplicaSets per deployment it manages, saving memory.
-	dep.Spec.RevisionHistoryLimit = pointer.Int32Ptr(1)
+	dep.Spec.RevisionHistoryLimit = pointer.Int32(1)
 
 	hash = HashDeploymentSpec(dep.Spec)
 	dep.Labels[DeploymentSpecHashLabelKey] = hash

pkg/api/client/clientset/versioned/clientset.go

@@ -1333,7 +1333,8 @@ func TestCompetingCRDOwnersExist(t *testing.T) {
 			expectedResult: true,
 		},
 	}
-	for _, tt := range tests {
+	for _, xt := range tests {
+		tt := xt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/api/client/clientset/versioned/fake/decorator.go

@@ -3852,7 +3852,8 @@ func TestUpdates(t *testing.T) {
 			in:   []*v1alpha1.ClusterServiceVersion{c, a, b},
 		},
 	}
-	for _, tt := range tests {
+	for _, xt := range tests {
+		tt := xt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/api/client/informers/externalversions/factory.go

@@ -12,7 +12,8 @@ import (
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned"
 )
 
-/* UpdateStatus can be used to update the status of the provided catalog source. Note that
+/*
+UpdateStatus can be used to update the status of the provided catalog source. Note that
 the caller is responsible for ensuring accurate status values in the catsrc argument (i.e.
 the status is used as-is).
 
@@ -34,7 +35,8 @@ func UpdateStatus(logger *logrus.Entry, client versioned.Interface, catsrc *v1al
 	return nil
 }
 
-/* UpdateStatusWithConditions can be used to update the status conditions for the provided catalog source.
+/*
+UpdateStatusWithConditions can be used to update the status conditions for the provided catalog source.
 This function will make no changes to the other status fields (those fields will be used as-is).
 If the provided conditions do not result in any status condition changes, then the API server will not be updated.
 Note that the caller is responsible for ensuring accurate status values for all other fields.
@@ -71,7 +73,8 @@ func UpdateStatusWithConditions(logger *logrus.Entry, client versioned.Interface
 	return nil
 }
 
-/* UpdateSpecAndStatusConditions can be used to update the catalog source with the provided status conditions.
+/*
+UpdateSpecAndStatusConditions can be used to update the catalog source with the provided status conditions.
 This will update the spec and status portions of the catalog source. Calls to the API server will occur
 even if the provided conditions result in no changes.
 
@@ -98,7 +101,8 @@ func UpdateSpecAndStatusConditions(logger *logrus.Entry, client versioned.Interf
 	return nil
 }
 
-/* RemoveStatusConditions can be used to remove the status conditions for the provided catalog source.
+/*
+RemoveStatusConditions can be used to remove the status conditions for the provided catalog source.
 This function will make no changes to the other status fields (those fields will be used as-is).
 If the provided conditions do not result in any status condition changes, then the API server will not be updated.
 Note that the caller is responsible for ensuring accurate status values for all other fields.

pkg/controller/install/deployment.go

@@ -35,8 +35,7 @@ type fakeStatusWriter struct {
 	k8scontrollerclient.StatusWriter
 }
 
-func (c fakeStatusWriter) Patch(ctx context.Context, obj k8scontrollerclient.Object, patch k8scontrollerclient.Patch, opts ...k8scontrollerclient.PatchOption) error {
-	patch, opts = convertApplyToMergePatch(patch, opts...)
+func (c fakeStatusWriter) Patch(ctx context.Context, obj k8scontrollerclient.Object, patch k8scontrollerclient.Patch, opts ...k8scontrollerclient.SubResourcePatchOption) error {
 	return c.StatusWriter.Patch(ctx, obj, patch, opts...)
 }