Skip to content

Commit ad41afe

Browse files
committed
Second batch of singleton labeling
1 parent 1427c2c commit ad41afe

File tree

54 files changed

+325
-26
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+325
-26
lines changed

substratevm/src/com.oracle.svm.core.graal.aarch64/src/com/oracle/svm/core/graal/aarch64/AArch64ReservedRegisters.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,15 @@
2828
import org.graalvm.nativeimage.Platforms;
2929

3030
import com.oracle.svm.core.ReservedRegisters;
31+
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
32+
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
33+
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Disallowed;
34+
import com.oracle.svm.core.traits.SingletonTraits;
3135

3236
import jdk.vm.ci.aarch64.AArch64;
3337
import jdk.vm.ci.code.Register;
3438

39+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Disallowed.class)
3540
public final class AArch64ReservedRegisters extends ReservedRegisters {
3641

3742
public static final Register THREAD_REGISTER = AArch64.r28;

substratevm/src/com.oracle.svm.core.graal.amd64/src/com/oracle/svm/core/graal/amd64/AMD64ReservedRegisters.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,15 @@
3232
import org.graalvm.nativeimage.Platforms;
3333

3434
import com.oracle.svm.core.ReservedRegisters;
35+
import com.oracle.svm.core.traits.BuiltinTraits.AllAccess;
36+
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
37+
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
38+
import com.oracle.svm.core.traits.SingletonTraits;
3539

3640
import jdk.vm.ci.amd64.AMD64;
3741
import jdk.vm.ci.code.Register;
3842

43+
@SingletonTraits(access = AllAccess.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
3944
public final class AMD64ReservedRegisters extends ReservedRegisters {
4045

4146
public static final Register THREAD_REGISTER = r15;

substratevm/src/com.oracle.svm.core.graal.llvm/src/com/oracle/svm/core/graal/llvm/image/LLVMCCompilerInvoker.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,16 @@
2828
import java.nio.file.Path;
2929
import java.util.Scanner;
3030

31+
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
32+
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
33+
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Disallowed;
34+
import com.oracle.svm.core.traits.SingletonTraits;
3135
import com.oracle.svm.core.util.UserError;
3236
import com.oracle.svm.core.util.VMError;
3337
import com.oracle.svm.hosted.c.codegen.CCompilerInvoker;
3438
import com.oracle.svm.hosted.image.LLVMToolchain;
3539

40+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Disallowed.class)
3641
public class LLVMCCompilerInvoker extends CCompilerInvoker {
3742

3843
public LLVMCCompilerInvoker(Path tempDirectory) {

substratevm/src/com.oracle.svm.core.graal.riscv64/src/com/oracle/svm/core/graal/riscv64/RISCV64ReservedRegisters.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,15 @@
2828
import org.graalvm.nativeimage.Platforms;
2929

3030
import com.oracle.svm.core.ReservedRegisters;
31+
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
32+
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
33+
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Disallowed;
34+
import com.oracle.svm.core.traits.SingletonTraits;
3135

3236
import jdk.vm.ci.code.Register;
3337
import jdk.vm.ci.riscv64.RISCV64;
3438

39+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Disallowed.class)
3540
public final class RISCV64ReservedRegisters extends ReservedRegisters {
3641

3742
public static final Register THREAD_REGISTER = RISCV64.x23;

substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/PosixLogHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,13 @@
3838
import com.oracle.svm.core.log.Log;
3939
import com.oracle.svm.core.thread.VMThreads;
4040
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
41-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
4241
import com.oracle.svm.core.traits.BuiltinTraits.RuntimeAccessOnly;
4342
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
4443
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
4544
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.InitialLayerOnly;
4645
import com.oracle.svm.core.traits.SingletonTraits;
4746

48-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
47+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Independent.class)
4948
@AutomaticallyRegisteredFeature
5049
class PosixLogHandlerFeature implements InternalFeature {
5150
@Override

substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/PosixVirtualMemoryProvider.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
import com.oracle.svm.core.posix.headers.Unistd;
5858
import com.oracle.svm.core.traits.BuiltinTraits.AllAccess;
5959
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
60-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
6160
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
6261
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
6362
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.InitialLayerOnly;
@@ -67,7 +66,7 @@
6766

6867
import jdk.graal.compiler.word.Word;
6968

70-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
69+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Independent.class)
7170
@AutomaticallyRegisteredFeature
7271
class PosixVirtualMemoryProviderFeature implements InternalFeature {
7372
@Override

substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/darwin/DarwinImageSingletonsFeature.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
import com.oracle.svm.core.imagelayer.ImageLayerBuildingSupport;
3232
import com.oracle.svm.core.os.ImageHeapProvider;
3333
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
34-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
34+
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
3535
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Disallowed;
3636
import com.oracle.svm.core.traits.SingletonTraits;
3737

38-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Disallowed.class)
38+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Disallowed.class)
3939
@AutomaticallyRegisteredFeature
4040
class DarwinImageSingletonsFeature implements InternalFeature {
4141
@Override

substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/linux/DumpLinuxOSInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
import com.oracle.svm.core.log.Log;
4242
import com.oracle.svm.core.os.RawFileOperationSupport;
4343
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
44-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
44+
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
4545
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
4646
import com.oracle.svm.core.traits.SingletonTraits;
4747

@@ -107,7 +107,7 @@ private static int countLineBytes(CCharPointer buffer, int len) {
107107
}
108108
}
109109

110-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
110+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Independent.class)
111111
@AutomaticallyRegisteredFeature
112112
class DumpLinuxOSInfoFeature implements InternalFeature {
113113
@Override

substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/linux/LinuxImageSingletonsFeature.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@
3434
import com.oracle.svm.core.imagelayer.ImageLayerBuildingSupport;
3535
import com.oracle.svm.core.os.ImageHeapProvider;
3636
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
37-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
37+
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
3838
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
3939
import com.oracle.svm.core.traits.SingletonTraits;
4040

41-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
41+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Independent.class)
4242
@AutomaticallyRegisteredFeature
4343
class LinuxImageSingletonsFeature implements InternalFeature {
4444
@Override

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateSegfaultHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
import com.oracle.svm.core.thread.VMThreads.SafepointBehavior;
6767
import com.oracle.svm.core.threadlocal.VMThreadLocalSupport;
6868
import com.oracle.svm.core.traits.BuiltinTraits.BuildtimeAccessOnly;
69-
import com.oracle.svm.core.traits.BuiltinTraits.NoLayeredCallbacks;
69+
import com.oracle.svm.core.traits.BuiltinTraits.SingleLayer;
7070
import com.oracle.svm.core.traits.SingletonLayeredInstallationKind.Independent;
7171
import com.oracle.svm.core.traits.SingletonTraits;
7272
import com.oracle.svm.util.ReflectionUtil;
@@ -76,7 +76,7 @@
7676
import jdk.graal.compiler.options.Option;
7777
import jdk.graal.compiler.word.Word;
7878

79-
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = NoLayeredCallbacks.class, layeredInstallationKind = Independent.class)
79+
@SingletonTraits(access = BuildtimeAccessOnly.class, layeredCallbacks = SingleLayer.class, layeredInstallationKind = Independent.class)
8080
@AutomaticallyRegisteredFeature
8181
class SubstrateSegfaultHandlerFeature implements InternalFeature {
8282
@Override

0 commit comments

Comments
 (0)