Skip to content

Commit c64eb75

Browse files
committed
[GR-70563] Fix sulong job name generation.
PullRequest: graal/22310
2 parents 02b5484 + a8f5edd commit c64eb75

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

sulong/ci/ci.jsonnet

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ local sc = (import "ci_common/sulong-common.jsonnet");
8787
$.sulong + sc.post_merge + $.common() + sc.labsjdkLatest + sc.windows_amd64 + sc.llvmBundled + sc.gateTags("build,sulongStandalone,interop") + { name: "gate-sulong-standalone-interop-jdk-latest-windows-amd64", timelimit: "1:00:00" },
8888
$.sulong + tier3 + $.common() + sc.labsjdkLatest + sc.windows_amd64 + sc.llvmBundled + sc.gateTags("build,nwcc,llvm") + { name: "gate-sulong-nwcc-llvm-jdk-latest-windows-amd64", timelimit: "30:00" },
8989
$.sulong + sc.post_merge + $.common() + sc.labsjdkLatest + sc.windows_amd64 + sc.llvmBundled + sc.requireGMP + sc.gateTags("build,gcc_c") + { name: "gate-sulong-gcc_c-jdk-latest-windows-amd64", timelimit: "45:00" },
90-
$.sulong + sc.post_merge + $.common() + sc.labsjdkLatest + sc.windows_amd64 + sc.llvmBundled + sc.requireGMP + sc.gateTags("build,gcc_cpp") + { name: "gate-sulong-gcc_cpp-jdk-latest-windows-amd64", timelimit: "45:00" },
90+
# GR-53974
91+
# $.sulong + sc.post_merge + $.common() + sc.labsjdkLatest + sc.windows_amd64 + sc.llvmBundled + sc.requireGMP + sc.gateTags("build,gcc_cpp") + { name: "gate-sulong-gcc_cpp-jdk-latest-windows-amd64", timelimit: "45:00" },
9192
],
9293

9394
standalone_builds::
@@ -111,13 +112,13 @@ local sc = (import "ci_common/sulong-common.jsonnet");
111112
],
112113
[
113114
tier2 + { name: "gate-sulong-test-ce-standalones-jvm-jdk-latest-linux-amd64", timelimit: "1:00:00" },
114-
sc.daily + { name: "daily-sulong-test-ce-standalones-jvm-jdk-latest-darwin-amd64", timelimit: "1:00:00", targets: [] },
115-
sc.daily + { name: "daily-sulong-test-ce-standalones-jvm-jdk-latest-windows-amd64", timelimit: "1:00:00", targets: [] } /* GR-50165 */,
115+
sc.daily + { name: "daily-sulong-test-ce-standalones-jvm-jdk-latest-darwin-amd64", timelimit: "1:00:00" },
116+
sc.daily + { name: "daily-sulong-test-ce-standalones-jvm-jdk-latest-windows-amd64", timelimit: "1:00:00" } /* GR-50165 */,
116117
tier3 + { name: "gate-sulong-test-ce-standalones-jvm-jdk-latest-linux-aarch64", timelimit: "1:00:00" },
117118
tier3 + { name: "gate-sulong-test-ce-standalones-jvm-jdk-latest-darwin-aarch64", timelimit: "1:00:00" },
118119
tier2 + { name: "gate-sulong-test-ce-standalones-native-jdk-latest-linux-amd64", timelimit: "1:30:00" },
119-
sc.daily + { name: "daily-sulong-test-ce-standalones-native-jdk-latest-darwin-amd64", timelimit: "1:00:00", targets: [] },
120-
sc.daily + { name: "daily-sulong-test-ce-standalones-native-jdk-latest-windows-amd64", timelimit: "1:00:00", targets: [] } /* GR-50165 */,
120+
sc.daily + { name: "daily-sulong-test-ce-standalones-native-jdk-latest-darwin-amd64", timelimit: "1:00:00" },
121+
sc.daily + { name: "daily-sulong-test-ce-standalones-native-jdk-latest-windows-amd64", timelimit: "1:00:00" } /* GR-50165 */,
121122
tier3 + { name: "gate-sulong-test-ce-standalones-native-jdk-latest-linux-aarch64", timelimit: "1:00:00" },
122123
tier3 + { name: "gate-sulong-test-ce-standalones-native-jdk-latest-darwin-aarch64", timelimit: "1:00:00" },
123124
]),

sulong/ci/ci_common/sulong-common.jsonnet

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,15 @@ local sulong_deps = common.deps.sulong;
2525
job:: error "job not set" + $.nameOrEmpty(self),
2626
bitcode_config:: [],
2727
sulong_config:: [],
28+
29+
/**
30+
* Normalize targets. Tier targets are semantically gate, independent of the actual frequency.
31+
* Reflect this in the job name.
32+
*/
33+
local normalized_targets =
34+
local norm(t) = if std.startsWith(t, "tier") then "gate" else t;
35+
std.uniq(std.map(norm, self.targets)),
36+
2837
gen_name_componentes::
2938
assert std.isArray(self.targets) : "targets must be an array" + $.nameOrEmpty(self);
3039
assert isNonEmptyString(self.suite) : "suite must be a non-empty string" + $.nameOrEmpty(self);
@@ -34,7 +43,7 @@ local sulong_deps = common.deps.sulong;
3443
assert isNonEmptyString(self.job) : "job must be a non-empty string" + $.nameOrEmpty(self);
3544
assert std.isArray(self.bitcode_config) : "bitcode_config must be an array" + $.nameOrEmpty(self);
3645
assert std.isArray(self.sulong_config) : "sulong_config must be an array" + $.nameOrEmpty(self);
37-
self.targets + [self.suite] + [self.job] + self.bitcode_config + self.sulong_config + [self.jdk_name] + [self.os] + [self.arch],
46+
normalized_targets + [self.suite] + [self.job] + self.bitcode_config + self.sulong_config + [self.jdk_name] + [self.os] + [self.arch],
3847
gen_name:: std.join("-", self.gen_name_componentes),
3948
},
4049

@@ -86,7 +95,7 @@ local sulong_deps = common.deps.sulong;
8695
notify_groups:: ["sulong"],
8796
},
8897

89-
post_merge:: $.sulong_notifications + common.frequencies.post_merge,
98+
post_merge:: $.sulong_notifications + { targets+: ["tier4"] },
9099
daily:: $.sulong_notifications + common.frequencies.daily,
91100
weekly:: $.sulong_notifications + common.frequencies.weekly,
92101

0 commit comments

Comments
 (0)