User is always DevelopmentSeed

[dereklieu]

This little guy is supposed to tell us all the users who made changes on the current map extent.

However, it only ever says DevelopmentSeed, making me think we're doing something wrong on the server-side, possibly in the bbox endpoint.

[edit] for clarity all the names are DevelopmentSeed even when I make a new road and zoom in to only see that road.

[kriscarle]

I was able to track this down, I had to join in the changesets and users tables and then update xml.js to use the new values instead of the hardcoded ones. I can put together a pull request.

knex.select('current_nodes.*', 'users.display_name as user', 'users.id as uid')
            .from('current_nodes')
            .leftJoin('changesets', 'current_nodes.changeset_id', 'changesets.id')
            .leftJoin('users', 'changesets.user_id', 'users.id')
            .where('current_nodes.id', nodeId),

[dereklieu]

Hey @kriscarle if you had time to put a PR, that'd be great. Thanks for looking into this!