Use synckit (#134)

* Use synckit

* test for other os

* fix for win

Author: ota-meshi

.github/workflows/NodeCI.yml

@@ -19,10 +19,20 @@ jobs:
             - name: Lint
               run: npm run lint
     test:
-        runs-on: ubuntu-latest
         strategy:
             matrix:
-                node-version: [12.x, 14.x, 16.x, 17.x]
+                node-version: [12.x, 14.x, 16.x, 17.x, 18.x]
+                os: [ubuntu-latest]
+                include:
+                    - node: 18.x
+                      os: windows-latest
+                    - node: 18.x
+                      os: macos-latest
+                    - node: 12.x
+                      os: windows-latest
+                    - node: 12.x
+                      os: macos-latest
+        runs-on: ${{ matrix.os }}
         steps:
             - uses: actions/checkout@v3
             - name: Use Node.js ${{ matrix.node-version }}

package.json

@@ -62,6 +62,7 @@
         "json-schema-migrate": "^2.0.0",
         "jsonc-eslint-parser": "^2.0.0",
         "minimatch": "^5.0.0",
+        "synckit": "^0.7.1",
         "toml-eslint-parser": "^0.4.0",
         "tunnel-agent": "^0.6.0",
         "yaml-eslint-parser": "^0.5.0"

src/utils/http-client/cli.ts

@@ -1,6 +1,7 @@
 import type { RequestOptions } from "https"
-import { spawnSync } from "child_process"
-import path from "path"
+import { createSyncFn } from "synckit"
+
+const getSync = createSyncFn(require.resolve("./worker"))
 
 /**
  * Synchronously GET Method
@@ -10,30 +11,5 @@ export function syncGet(
     options?: RequestOptions,
     httpModulePath?: string,
 ): string {
-    const httpScriptPath = require.resolve("./cli")
-    const execPath = process.execPath
-    const optionsJSON = JSON.stringify(options ?? {})
-    const cliArgs = [
-        httpScriptPath,
-        url,
-        optionsJSON,
-        JSON.stringify({ httpModulePath }),
-    ]
-    if (path.extname(httpScriptPath) === ".ts") {
-        cliArgs.unshift("--require", "ts-node/register/transpile-only")
-    }
-    const result = spawnSync(execPath, cliArgs, {
-        windowsHide: true,
-        maxBuffer: Infinity,
-    })
-
-    if (result.error) {
-        throw result.error
-    }
-    if (result.status !== 0) {
-        throw new Error(
-            `Failed:\n${result.stdout.toString()}\n${result.stderr.toString()}`,
-        )
-    }
-    return result.stdout.toString("utf8")
+    return getSync(url, options, httpModulePath)
 }

src/utils/http-client/sync-http.ts

@@ -0,0 +1,9 @@
+import type { RequestOptions } from "https"
+import { runAsWorker } from "synckit"
+import { get } from "./http"
+
+runAsWorker(
+    async (url: string, options?: RequestOptions, httpModulePath?: string) => {
+        return get(url, options, httpModulePath)
+    },
+)

src/utils/http-client/worker.ts

@@ -12,7 +12,9 @@ const FIXTURES_ROOT = path.join(__dirname, "../../../fixtures/utils/ast/js")
 describe("AST for JS.", () => {
     for (const filename of listupInput(FIXTURES_ROOT)) {
         it(filename.slice(FIXTURES_ROOT.length), () => {
-            const input = fs.readFileSync(filename, "utf8")
+            const input = fs
+                .readFileSync(filename, "utf8")
+                .replace(/\r\n/gu, "\n")
             const outputFile = filename.replace(/input.js$/, "output.json")
 
             const linter = new Linter()
@@ -53,7 +55,9 @@ describe("AST for JS.", () => {
                 )
             }
 
-            const output = JSON.parse(fs.readFileSync(outputFile, "utf8"))
+            const output = JSON.parse(
+                fs.readFileSync(outputFile, "utf8").replace(/\r\n/gu, "\n"),
+            )
 
             assert.deepStrictEqual(result, output)
         })