Skip to content

TST: Added test that checks if df.sum() results in concatenation instead of dtype coercion to float64 or int64 #63260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 5 commits into from
Dec 6, 2025
+20 −0
Merged

TST: Added test that checks if df.sum() results in concatenation instead of dtype coercion to float64 or int64 #63260

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2a062b
Added test_sum_string_dtype_coercion that checks summing numeric stri…
AbelJSanchez Dec 4, 2025
ad91b9c
Merge remote-tracking branch 'upstream/main' into sum-string-dtype
AbelJSanchez Dec 5, 2025
8f5b427
Modified test to use pytest.mark.parametrize instead of setting up 3 …
AbelJSanchez Dec 5, 2025
358b2d4
Merge remote-tracking branch 'upstream/main' into sum-string-dtype
AbelJSanchez Dec 6, 2025
719b9e4
Moved Series and Dataframe calls to the body of the test
AbelJSanchez Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pandas/tests/frame/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,30 @@ def test_sum_bools(self):
bools = isna(df)
assert bools.sum(axis=1)[0] == 10

@pytest.mark.parametrize(
"df, expected",
[
(
DataFrame({"a": ["483", "3"], "b": ["94", "759"]}),
Series(["48394", "3759"]),
),
(
DataFrame({"a": ["483.948", "3.0"], "b": ["94.2", "759.93"]}),
Series(["483.94894.2", "3.0759.93"]),
),
(
DataFrame({"a": ["483", "3.0"], "b": ["94.2", "79"]}),
Series(["48394.2", "3.079"]),
Copy link
Member

@mroeschke mroeschke Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the DataFrame and Series calls in the body of the test?

Copy link
Contributor Author

@AbelJSanchez AbelJSanchez Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Will make changes tonight and resubmit.

),
],
)
def test_sum_string_dtype_coercion(self, df, expected):
# GH#22642
# Check that summing numeric strings results in concatenation
# and not conversion to dtype int64 or float64
result = df.sum(axis=1)
tm.assert_series_equal(result, expected)

# ----------------------------------------------------------------------
# Index of max / min

Expand Down
Loading