Changed parameter handling behavior

Translation seems to be useless, the spec is confusing
Made system to properly parse and describe parameters according to OpenAPI 3 spec

Author: Wicpar

src/main/kotlin/com/papsign/ktor/openapigen/annotations/parameters/PathParam.kt

@@ -1,8 +1,14 @@
 package com.papsign.ktor.openapigen.annotations.parameters
 
 import com.papsign.ktor.openapigen.openapi.ParameterLocation
+import com.papsign.ktor.openapigen.parameters.PathParamStyle
 
 @Target(AnnotationTarget.FIELD, AnnotationTarget.PROPERTY, AnnotationTarget.VALUE_PARAMETER)
 @Retention(AnnotationRetention.RUNTIME)
 @APIParam(ParameterLocation.path)
-annotation class PathParam(val description: String, val required: Boolean = true, val deprecated: Boolean = false)
+annotation class PathParam(
+    val description: String,
+    val style: PathParamStyle = PathParamStyle.simple,
+    val explode: Boolean = false,
+    val deprecated: Boolean = false
+)

src/main/kotlin/com/papsign/ktor/openapigen/annotations/parameters/QueryParam.kt

@@ -1,8 +1,15 @@
 package com.papsign.ktor.openapigen.annotations.parameters
 
 import com.papsign.ktor.openapigen.openapi.ParameterLocation
+import com.papsign.ktor.openapigen.parameters.QueryParamStyle
 
 @Target(AnnotationTarget.FIELD, AnnotationTarget.PROPERTY, AnnotationTarget.VALUE_PARAMETER)
 @Retention(AnnotationRetention.RUNTIME)
 @APIParam(ParameterLocation.query)
-annotation class QueryParam(val description: String, val allowEmptyValues: Boolean = false, val required: Boolean = true, val deprecated: Boolean = false)
+annotation class QueryParam(
+    val description: String,
+    val style: QueryParamStyle = QueryParamStyle.form,
+    val explode: Boolean = false,
+    val allowEmptyValues: Boolean = false,
+    val deprecated: Boolean = false
+)

src/main/kotlin/com/papsign/ktor/openapigen/modules/handlers/RequestHandlerModule.kt

@@ -7,7 +7,7 @@ import com.papsign.ktor.openapigen.classLogger
 import com.papsign.ktor.openapigen.content.type.BodyParser
 import com.papsign.ktor.openapigen.content.type.ContentTypeProvider
 import com.papsign.ktor.openapigen.content.type.SelectedParser
-import com.papsign.ktor.openapigen.generator.ParamBuilder
+import com.papsign.ktor.openapigen.parameters.ParamBuilder
 import com.papsign.ktor.openapigen.modules.ModuleProvider
 import com.papsign.ktor.openapigen.modules.ofClass
 import com.papsign.ktor.openapigen.modules.openapi.OperationModule

src/main/kotlin/com/papsign/ktor/openapigen/modules/handlers/RouteHandler.kt

@@ -10,6 +10,9 @@ import com.papsign.ktor.openapigen.modules.providers.MethodProvider
 import com.papsign.ktor.openapigen.modules.providers.PathProvider
 import com.papsign.ktor.openapigen.openapi.Operation
 import com.papsign.ktor.openapigen.openapi.PathItem
+import com.papsign.ktor.openapigen.parameters.parsers.NoTranslation
+import com.papsign.ktor.openapigen.parameters.parsers.OpenAPIPathSegmentTranslator
+import com.papsign.ktor.openapigen.parameters.parsers.ParameterHandler
 import org.slf4j.Logger
 import org.slf4j.LoggerFactory
 
@@ -21,7 +24,8 @@ object RouteHandler: HandlerModule {
         val methods = provider.ofClass<MethodProvider>()
         if (methods.size > 1) error("API cannot have two methods simultaneously: ${methods.map { it.method.value }}")
         val paths = provider.ofClass<PathProvider>()
-        val path = "/${paths.map { it.path.trim('/') }.filter { it.isNotBlank() }.joinToString("/")}"
+        val translator = getTranslator(provider)
+        val path = "/${paths.flatMap { it.path.split('/').filter(String::isNotEmpty).map(translator::translateSegment) }.joinToString("/")}"
         val operationModules = provider.ofClass<OperationModule>()
         apiGen.api.paths.getOrPut(path) { PathItem() }.also {pathItem ->
             methods.forEach {
@@ -35,4 +39,11 @@ object RouteHandler: HandlerModule {
         }
         log.trace("Registered $path::${methods.map { it.method.value }} with OpenAPI description with ${provider.ofClass<SelectedModule>().map { it.module::class.simpleName }}")
     }
+
+    private fun getTranslator(provider: ModuleProvider<*>): OpenAPIPathSegmentTranslator {
+        val translator = provider.ofClass<OpenAPIPathSegmentTranslator>()
+        if (translator.size > 1) log.warn("Too many Path Segment Translators, choosing first: $translator")
+        if (translator.isEmpty()) log.debug("No Path Segment Translator, choosing default")
+        return translator.firstOrNull() ?: NoTranslation
+    }
 }

src/main/kotlin/com/papsign/ktor/openapigen/modules/openapi/HandlerModule.kt

@@ -3,7 +3,8 @@ package com.papsign.ktor.openapigen.modules.openapi
 import com.papsign.ktor.openapigen.OpenAPIGen
 import com.papsign.ktor.openapigen.modules.ModuleProvider
 import com.papsign.ktor.openapigen.modules.OpenAPIModule
+import com.papsign.ktor.openapigen.parameters.parsers.ParameterHandler
 
 interface HandlerModule: OpenAPIModule {
     fun configure(apiGen: OpenAPIGen, provider: ModuleProvider<*>)
-}
+}

src/main/kotlin/com/papsign/ktor/openapigen/modules/providers/ParameterProvider.kt

@@ -1,9 +1,9 @@
 package com.papsign.ktor.openapigen.modules.providers
 
-import com.papsign.ktor.openapigen.generator.ParamBuilder
+import com.papsign.ktor.openapigen.parameters.ParamBuilder
 import com.papsign.ktor.openapigen.modules.OpenAPIModule
 import com.papsign.ktor.openapigen.openapi.Parameter
 
 interface ParameterProvider: OpenAPIModule {
     fun  getParameters(builder: ParamBuilder): List<Parameter<*>>
-}
+}

src/main/kotlin/com/papsign/ktor/openapigen/openapi/OpenAPIModels.kt

@@ -1,5 +1,7 @@
 package com.papsign.ktor.openapigen.openapi
 
+import com.papsign.ktor.openapigen.parameters.ParameterStyle
+
 data class ExternalDocumentation(
     var url: String,
     var description: String? = null
@@ -14,7 +16,9 @@ data class Parameter<T>(
     var allowEmptyValue: Boolean? = null,
     var schema: Schema<T>? = null,
     var example: T? = null,
-    var examples: MutableMap<String, T>? = null
+    var examples: MutableMap<String, T>? = null,
+    var style: ParameterStyle? = null,
+    var explode: Boolean = false
     // incomplete
 )
 

…tor/openapigen/generator/ParamBuilder.kt …or/openapigen/parameters/ParamBuilder.ktsrc/main/kotlin/com/papsign/ktor/openapigen/generator/ParamBuilder.kt renamed to src/main/kotlin/com/papsign/ktor/openapigen/parameters/ParamBuilder.kt src/main/kotlin/com/papsign/ktor/openapigen/generator/ParamBuilder.kt renamed to src/main/kotlin/com/papsign/ktor/openapigen/parameters/ParamBuilder.kt

@@ -1,4 +1,4 @@
-package com.papsign.ktor.openapigen.generator
+package com.papsign.ktor.openapigen.parameters
 
 import com.papsign.ktor.openapigen.OpenAPIGen
 import com.papsign.ktor.openapigen.annotations.parameters.PathParam
@@ -32,13 +32,17 @@ class ParamBuilder(val apiGen: OpenAPIGen, val provider: ModuleProvider<*>) {
             it.description = description
             it.allowEmptyValue = allowEmptyValues
             it.deprecated = deprecated
+            it.style = style
+            it.explode = explode
         }
     }
 
     fun PathParam.createParam(param: KParameter): Parameter<*> {
         return createParam(param, apiParam.`in`) {
             it.description = description
             it.deprecated = deprecated
+            it.style = style
+            it.explode = explode
         }
     }
 
@@ -52,4 +56,4 @@ class ParamBuilder(val apiGen: OpenAPIGen, val provider: ModuleProvider<*>) {
             config(it)
         }
     }
-}
+}

src/main/kotlin/com/papsign/ktor/openapigen/parameters/ParameterStyle.kt

@@ -0,0 +1,5 @@
+package com.papsign.ktor.openapigen.parameters
+
+interface ParameterStyle {
+    val name: String
+}

src/main/kotlin/com/papsign/ktor/openapigen/parameters/PathParamStyle.kt

@@ -0,0 +1,5 @@
+package com.papsign.ktor.openapigen.parameters
+
+enum class PathParamStyle(val prefix: String): ParameterStyle {
+    simple(""), label("."), matrix(";")
+}