Changed variable name and added a bit of comments

Author: abergs

Fido2Demo/Controller.cs

@@ -31,7 +31,7 @@ public MyController(IConfiguration config)
                 ServerDomain = config["fido2:serverDomain"],
                 ServerName = "Fido2 test",
                 Origin = config["fido2:origin"],
-                MetadataService = MDSMetadata.Instance(config["fido2:MDSAccessKey"], config["fido2:MDSCacheDir"])
+                MetadataService = MDSMetadata.Instance(config["fido2:MDSAccessKey"], config["fido2:MDSCacheDirPath"])
             });
         }
 

Fido2Demo/TestController.cs

@@ -35,7 +35,7 @@ public TestController(IConfiguration config)
                 ServerDomain = config["fido2:serverDomain"],
                 ServerName = "Fido2 test",
                 Origin = config["fido2:origin"],
-                MetadataService = MDSMetadata.Instance(config["fido2:MDSAccessKey"], config["fido2:MDSCacheDir"])
+                MetadataService = MDSMetadata.Instance(config["fido2:MDSAccessKey"], config["fido2:MDSCacheDirPath"])
             });
         }
 

fido2-net-lib/MetadataService.cs

@@ -370,14 +370,20 @@ private MDSMetadata(string accessToken, string cachedirPath)
             // If the payload count is zero, we've failed to load metadata
             if (0 == payload.Count) throw new Fido2VerificationException("Failed to load MDS metadata");
         }
-        public static IMetadataService Instance(string accesskey, string cachedir)
+        /// <summary>
+        /// Returns or creates an instance of the MetadataSerivce. The paramters will only be used when the singleton is not alreayd created.
+        /// </summary>
+        /// <param name="accesskey"></param>
+        /// <param name="cachedirPath"></param>
+        /// <returns></returns>
+        public static IMetadataService Instance(string accesskey, string cachedirPath)
         {
             if (null == mDSMetadata)
             {
                 lock (syncRoot)
                 {
                     if (null == mDSMetadata)
-                        mDSMetadata = new MDSMetadata(accesskey, cachedir);
+                        mDSMetadata = new MDSMetadata(accesskey, cachedirPath);
                 }
             }
             return mDSMetadata;