Skip to content
This repository was archived by the owner on Feb 7, 2023. It is now read-only.

Commit e075c39

Browse files
committed
alignment with edition-node-gulp dependencies
1 parent 64abb92 commit e075c39

File tree

135 files changed

+2408
-10435
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

135 files changed

+2408
-10435
lines changed

.github/CONTRIBUTING.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Contributing to Patternlab Node
2+
If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse.
3+
4+
No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet, or add some more unit tests.
5+
6+
## Guidelines
7+
1. Please keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
8+
2. _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer about making a dedicated `feature-branch`
9+
3. If you can, add some unit tests using the existing patterns in the `./test` directory
10+
11+
##Coding style
12+
Two files combine within the project to define and maintain our coding style.
13+
14+
* The `.editorconfig` controls spaces / tabs within supported editors. Check out their [site](http://editorconfig.org/).
15+
* The `.eslintrc` defines our javascript standards. Some editors will evaluate this real-time - otherwise it's run using `grunt|gulp build`

.github/ISSUE_TEMPLATE.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<!-- before posting an issue, try chatting on https://gitter.im/pattern-lab/node -->
2+
<!-- before posting an issue, verify you are running at least Node 4 or 5 AND Gulp 4 -->
3+
4+
I am using Edition Node Gulp `vX.X.X` on `Windows | Mac | Linux`, with Node `vX.X.X`, Gulp-CLI `vX.X.X` and Gulp `vX.X.X`.
5+
6+
##### Expected Behavior
7+
8+
9+
##### Actual Behavior
10+
11+
12+
##### Steps to Reproduce

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<!-- **Please read the contribution guidelines first, and target the `dev` branch!** -->
2+
3+
Addresses #
4+
5+
Summary of changes:

Gruntfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ module.exports = function (grunt) {
3333
grunt.registerTask('patternlab', 'create design systems with atomic design', function (arg) {
3434

3535
if (arguments.length === 0) {
36-
pl.build(getConfiguredCleanOption());
36+
pl.build(function(){}, getConfiguredCleanOption());
3737
}
3838

3939
if (arg && arg === 'version') {
4040
pl.version();
4141
}
4242

4343
if (arg && arg === "patternsonly") {
44-
pl.patternsonly(getConfiguredCleanOption());
44+
pl.patternsonly(function(){},getConfiguredCleanOption());
4545
}
4646

4747
if (arg && arg === "help") {

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
"grunt-contrib-watch": "^1.0.0",
1111
"grunt-contrib-copy": "^1.0.0",
1212
"minimist": "^1.2.0",
13-
"patternlab-node": "pattern-lab/patternlab-node#v2.0.0-alpha",
14-
"styleguidekit-assets-default": "pattern-lab/styleguidekit-assets-default#feature-panels",
15-
"styleguidekit-mustache-default": "pattern-lab/styleguidekit-mustache-default#feature-panels",
13+
"patternlab-node": "^2.0.0",
14+
"styleguidekit-assets-default": "^3.0.0",
15+
"styleguidekit-mustache-default": "^3.0.0"
1616
},
1717
"keywords": [
1818
"Pattern Lab",

source/_annotations/annotations.js

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,9 @@
11
var comments = {
2-
"comments" : [
3-
{
4-
"el": "header[role=banner]",
5-
"title" : "Masthead",
6-
"comment": "The main header of the site doesn't take up too much screen real estate in order to keep the focus on the core content. It's using a linear CSS gradient instead of a background image to give greater design flexibility and reduce HTTP requests."
7-
},
8-
{
9-
"el": ".logo",
10-
"title" : "Logo",
11-
"comment": "The logo image is an SVG file, which ensures that the logo displays crisply even on high resolution displays. A PNG fallback is provided for browsers that don't support SVG images.</p><p>Further reading: <a href=\"http://bradfrostweb.com/blog/mobile/hi-res-optimization/\">Optimizing Web Experiences for High Resolution Screens</a></p>"
12-
},
13-
{
14-
"el": "#nav",
15-
"title" : "Navigation",
16-
"comment": "<p>Navigation for adaptive web experiences can be tricky. Top navigations are typical on desktop sites, but mobile screen sizes don't give us the luxury of space. We're dealing with this situation by creating a simple menu anchor that toggles the main navigation on small screens. This is just one method. <a href=\"http://bagcheck.com/\">Bagcheck</a> and <a href=\"http://contentsmagazine.com/\">Contents Magazine</a> add an anchor in the header that jumps users to the navigation which is placed in the footer. This solution works well because it doesn't require any Javascript in order to work. Other methods exist too. For example, <a href=\"http://m.espn.com\">ESPN's mobile navigation</a> overlays the main content of the page.</p><p>The nav is only hidden when a certain level of javascript is supported in order to ensure that users with little/poor javascript support can still access the navigation. Once the screen size is large enough to accommodate the nav, we show the main navigation links and hide the menu anchor.<p><p>See also: <a href=\"http://bradfrostweb.com/blog/web/responsive-nav-patterns/\">Responsive Navigation Patterns</a></p>"
17-
},
18-
{
19-
"el": ".search-form",
20-
"title" : "Search",
21-
"comment": "<p>Search is an incredibly important priority, especially for mobile. It is a great idea to give users the ability to jump directly to what they are looking for without forcing them to wade through your site's navigation. Check out the <a href=\"http://burton.com\">Burton</a> and <a href=\"http://yelp.com\">Yelp</a> mobile sites for great examples of experiences that prioritize search.</p><p>We're also using the <a href=\"http://dev.w3.org/html5/markup/input.search.html\">HTML5 search input type</a>, which is great for mobile devices that can <a href=\"http://diveintohtml5.info/forms.html\">bring up the appropriate virtual keyboard</a> for many smartphones. And like the main header navigation, we're hiding the search form on small screens to save space. Clicking the search anchor toggles the form. </p>"
22-
},
23-
{
24-
"el": ".article-header h1",
25-
"title" : "Article Header",
26-
"comment": "<p>The article header should be no more than 140 characters. </p>"
27-
},
28-
{
29-
"el": ".block-hero",
30-
"title" : "Hero",
31-
"comment": "<p>The hero area highlights one major story using a large image and a captivating headline.</p>"
32-
}
33-
]
2+
"comments" : [
3+
{
4+
"el": "#colors",
5+
"title" : "Special Markup and Styling",
6+
"comment": "This code uses pattern-scaffolding.css in the `source/css/` directory."
7+
}
8+
]
349
};

source/_data/data.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,4 @@
9090
{ },
9191
{ }
9292
]
93-
}
93+
}

source/_data/listitems.json

Lines changed: 97 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@
1313
"rectangle": {
1414
"src": "http://placeimg.com/400/300/tech",
1515
"alt": "Rectangle"
16+
},
17+
"landscape-4x3": {
18+
"src": "http://placeimg.com/400/300/tech",
19+
"alt": "4x3 Image"
20+
},
21+
"landscape-16x9": {
22+
"src": "http://placeimg.com/640/360/tech",
23+
"alt": "16x9 Image"
1624
}
1725
},
1826
"headline": {
@@ -78,6 +86,14 @@
7886
"rectangle": {
7987
"src": "http://placeimg.com/400/300/people",
8088
"alt": "Rectangle"
89+
},
90+
"landscape-4x3": {
91+
"src": "http://placeimg.com/400/300/people",
92+
"alt": "4x3 Image"
93+
},
94+
"landscape-16x9": {
95+
"src": "http://placeimg.com/640/360/people",
96+
"alt": "16x9 Image"
8197
}
8298
},
8399
"headline": {
@@ -143,6 +159,14 @@
143159
"rectangle": {
144160
"src": "http://placeimg.com/400/300/nature",
145161
"alt": "Rectangle"
162+
},
163+
"landscape-4x3": {
164+
"src": "http://placeimg.com/400/300/nature",
165+
"alt": "4x3 Image"
166+
},
167+
"landscape-16x9": {
168+
"src": "http://placeimg.com/640/360/nature",
169+
"alt": "16x9 Image"
146170
}
147171
},
148172
"headline": {
@@ -208,6 +232,14 @@
208232
"rectangle": {
209233
"src": "http://placeimg.com/400/300/people/grayscale",
210234
"alt": "Rectangle"
235+
},
236+
"landscape-4x3": {
237+
"src": "http://placeimg.com/400/300/people/greyscale",
238+
"alt": "4x3 Image"
239+
},
240+
"landscape-16x9": {
241+
"src": "http://placeimg.com/640/360/people/greyscale",
242+
"alt": "16x9 Image"
211243
}
212244
},
213245
"headline": {
@@ -273,6 +305,14 @@
273305
"rectangle": {
274306
"src": "http://placeimg.com/400/300/arch",
275307
"alt": "Rectangle"
308+
},
309+
"landscape-4x3": {
310+
"src": "http://placeimg.com/400/300/arch",
311+
"alt": "4x3 Image"
312+
},
313+
"landscape-16x9": {
314+
"src": "http://placeimg.com/640/360/arch",
315+
"alt": "16x9 Image"
276316
}
277317
},
278318
"headline": {
@@ -338,6 +378,14 @@
338378
"rectangle": {
339379
"src": "http://placeimg.com/400/300/people/grayscale",
340380
"alt": "Rectangle"
381+
},
382+
"landscape-4x3": {
383+
"src": "http://placeimg.com/400/300/people/grayscale",
384+
"alt": "4x3 Image"
385+
},
386+
"landscape-16x9": {
387+
"src": "http://placeimg.com/640/360/people/grayscale",
388+
"alt": "16x9 Image"
341389
}
342390
},
343391
"headline": {
@@ -403,6 +451,14 @@
403451
"rectangle": {
404452
"src": "http://placeimg.com/400/300/any",
405453
"alt": "Rectangle"
454+
},
455+
"landscape-4x3": {
456+
"src": "http://placeimg.com/400/300/any",
457+
"alt": "4x3 Image"
458+
},
459+
"landscape-16x9": {
460+
"src": "http://placeimg.com/640/360/any",
461+
"alt": "16x9 Image"
406462
}
407463
},
408464
"headline": {
@@ -468,6 +524,14 @@
468524
"rectangle": {
469525
"src": "http://placeimg.com/400/300/any/grayscale",
470526
"alt": "Rectangle"
527+
},
528+
"landscape-4x3": {
529+
"src": "http://placeimg.com/400/300/any/grayscale",
530+
"alt": "4x3 Image"
531+
},
532+
"landscape-16x9": {
533+
"src": "http://placeimg.com/640/360/any/grayscale",
534+
"alt": "16x9 Image"
471535
}
472536
},
473537
"headline": {
@@ -533,6 +597,14 @@
533597
"rectangle": {
534598
"src": "http://placeimg.com/400/300/any/sepia",
535599
"alt": "Rectangle"
600+
},
601+
"landscape-4x3": {
602+
"src": "http://placeimg.com/400/300/any/sepia",
603+
"alt": "4x3 Image"
604+
},
605+
"landscape-16x9": {
606+
"src": "http://placeimg.com/640/360/any/sepia",
607+
"alt": "16x9 Image"
536608
}
537609
},
538610
"headline": {
@@ -598,6 +670,14 @@
598670
"rectangle": {
599671
"src": "http://placeimg.com/400/300/arch/grayscale",
600672
"alt": "Rectangle"
673+
},
674+
"landscape-4x3": {
675+
"src": "http://placeimg.com/400/300/arch/grayscale",
676+
"alt": "4x3 Image"
677+
},
678+
"landscape-16x9": {
679+
"src": "http://placeimg.com/640/360/arch/grayscale",
680+
"alt": "16x9 Image"
601681
}
602682
},
603683
"headline": {
@@ -663,6 +743,14 @@
663743
"rectangle": {
664744
"src": "http://placeimg.com/400/300/arch/sepia",
665745
"alt": "Rectangle"
746+
},
747+
"landscape-4x3": {
748+
"src": "http://placeimg.com/400/300/arch/sepia",
749+
"alt": "4x3 Image"
750+
},
751+
"landscape-16x9": {
752+
"src": "http://placeimg.com/640/360/arch/sepia",
753+
"alt": "16x9 Image"
666754
}
667755
},
668756
"headline": {
@@ -728,6 +816,14 @@
728816
"rectangle": {
729817
"src": "http://placeimg.com/400/300/people/sepia",
730818
"alt": "Rectangle"
819+
},
820+
"landscape-4x3": {
821+
"src": "http://placeimg.com/400/300/people/sepia",
822+
"alt": "4x3 Image"
823+
},
824+
"landscape-16x9": {
825+
"src": "http://placeimg.com/640/360/people/sepia",
826+
"alt": "16x9 Image"
731827
}
732828
},
733829
"headline": {
@@ -779,4 +875,4 @@
779875
},
780876
"seconds": "56"
781877
}
782-
}
878+
}

source/_meta/_00-head.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
<meta name="viewport" content="width=device-width" />
77

88
<link rel="stylesheet" href="../../css/style.css?{{ cacheBuster }}" media="all" />
9+
<link rel="stylesheet" href="../../css/pattern-scaffolding.css?{{ cacheBuster }}" media="all" />
910

1011
<!-- Begin Pattern Lab (Required for Pattern Lab to run properly) -->
1112
{{{ patternLabHead }}}
1213
<!-- End Pattern Lab -->
1314

1415
</head>
1516
<body class="{{ bodyClass }}">
16-

source/_meta/_01-foot.mustache

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
2-
<!--DO NOT REMOVE-->
3-
{{{ patternLabFoot }}}
4-
5-
</body>
6-
</html>
1+
2+
<!--DO NOT REMOVE-->
3+
{{{ patternLabFoot }}}
4+
5+
</body>
6+
</html>

0 commit comments

Comments
 (0)