refactor: code style optimizations (#1314)

* chore(beautify): dependency reordering after npm i

* refactor: eslint feedback / prefer-const

'matches' is never reassigned. Use 'const' instead

* refactor: eslint feedback / prettier

* refactor: eslint feedback / no-shadow

'e' is already declared in the upper scope on line 202 column 24

* refactor: eslint feedback / no-shadow

'port' is already declared in the upper scope on line 28 column 9

* chore: typo

* test(eslint): error / Unexpected var, use let or const instead / no-var

* refactor: eslint feedback / prettier/prettier

* refactor(test): equals() is deprecated, replaced by equal()

@deprecated — use equal() instead.

'equals' is deprecated.ts(6385)
index.d.ts(53, 8): The declaration was marked as deprecated here.

* refactor: removed unused variables

'fs' is declared but its value is never read.ts(6133)

* refactor: eslint & prettier fixes

* refactor: code formatting via prettier

* Revert "refactor: removed unused variables"

This reverts commit fd3964c.

Author: mfranzke

package.json

@@ -10,17 +10,17 @@
     ]
   },
   "dependencies": {
+    "@auto-it/released": "^9.40.5",
     "@babel/plugin-proposal-decorators": "^7.13.5",
     "@babel/plugin-syntax-jsx": "^7.12.13",
+    "auto": "^9.40.5",
     "babel-eslint": "^10.0.2",
     "eslint": "^6.1.0",
     "eslint-config-airbnb-base": "^14.0.0",
     "eslint-config-prettier": "^6.0.0",
     "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-prettier": "^3.1.0",
     "lerna": "3.17.0",
-    "auto": "^9.40.5",
-    "@auto-it/released": "^9.40.5",
     "prettier": "^2.2.1",
     "pretty-quick": "^3.1.0"
   },

packages/cli/bin/archive.js

@@ -31,7 +31,7 @@ function exportPatterns(config) {
     );
   });
 
-  archive.on('error', function(err) {
+  archive.on('error', function (err) {
     throw new TypeError(
       `export: An error occured during zipping the patterns: ${err}`
     );

packages/cli/bin/ask.js

@@ -12,8 +12,8 @@ const ask = inquirer.prompt;
  * @param {object} options - Options passed in from CLI
  * @param {boolean} options.force - Flag whether to force install in existing project directory. May overwrite stuff.
  */
-const init = options =>
-  wrapsAsync(function*() {
+const init = (options) =>
+  wrapsAsync(function* () {
     /**
      * @property {string} project_root="./" - Path to the project root directory
      * @property {string|Symbol} edition - The name of the edition npm package or a Symbol for no install

packages/cli/bin/cli-actions/build.js

@@ -3,8 +3,8 @@ const buildPatterns = require('../build');
 const resolveConfig = require('../resolve-config');
 const { error, info, wrapAsync } = require('../utils');
 
-const build = options =>
-  wrapAsync(function*() {
+const build = (options) =>
+  wrapAsync(function* () {
     try {
       const config = yield resolveConfig(options.parent.config);
       yield buildPatterns(config, options);

packages/cli/bin/cli-actions/disable.js

@@ -10,8 +10,8 @@ const writeJsonAsync = require('../utils').writeJsonAsync;
  * @desc Handles deactivation of starterkits/plugins
  * @param {object} options
  */
-const enable = options =>
-  wrapAsync(function*() {
+const enable = (options) =>
+  wrapAsync(function* () {
     const {
       parent: { config: configPath },
       plugins,
@@ -24,7 +24,7 @@ const enable = options =>
       spinner.succeed(
         `⊙ patternlab → Disable following plugins: ${plugins.join(', ')}`
       );
-      plugins.map(plugin => {
+      plugins.map((plugin) => {
         if (_.has(config, `plugins[${plugin}]`)) {
           _.set(config, `plugins[${plugin}]['enabled']`, false);
           spinner.succeed(

packages/cli/bin/cli-actions/enable.js

@@ -10,8 +10,8 @@ const writeJsonAsync = require('../utils').writeJsonAsync;
  * @desc Handles activation of starterkits/plugins
  * @param {object} options
  */
-const enable = options =>
-  wrapAsync(function*() {
+const enable = (options) =>
+  wrapAsync(function* () {
     const {
       parent: { config: configPath },
       plugins,
@@ -24,7 +24,7 @@ const enable = options =>
       spinner.succeed(
         `⊙ patternlab → Enable following plugins: ${plugins.join(', ')}`
       );
-      plugins.map(plugin => {
+      plugins.map((plugin) => {
         if (_.has(config, `plugins[${plugin}]`)) {
           _.set(config, `plugins[${plugin}]['enabled']`, true);
           spinner.succeed(`⊙ patternlab → Enabled following plugin: ${plugin}`);

packages/cli/bin/cli-actions/export.js

@@ -3,8 +3,8 @@ const archive = require('../archive');
 const resolveConfig = require('../resolve-config');
 const wrapAsync = require('../utils').wrapAsync;
 
-const _export = options =>
-  wrapAsync(function*() {
+const _export = (options) =>
+  wrapAsync(function* () {
     const config = yield resolveConfig(options.parent.config);
     archive(config);
   });

packages/cli/bin/cli-actions/init.js

@@ -16,8 +16,8 @@ const defaultPatternlabConfig = patternlab.getDefaultConfig();
 // https://github.com/TehShrike/deepmerge#overwrite-array
 const overwriteMerge = (destinationArray, sourceArray, options) => sourceArray;
 
-const init = options =>
-  wrapAsync(function*() {
+const init = (options) =>
+  wrapAsync(function* () {
     const sourceDir = 'source';
     const publicDir = 'public';
     const exportDir = 'pattern_exports';

packages/cli/bin/cli-actions/install.js

@@ -11,8 +11,8 @@ const writeJsonAsync = require('../utils').writeJsonAsync;
  * @desc Handles async install and activation of starterkits/plugins
  * @param {object} options
  */
-const install = options =>
-  wrapAsync(function*() {
+const install = (options) =>
+  wrapAsync(function* () {
     const config = yield resolveConfig(options.parent.config);
 
     const spinner = ora(
@@ -21,8 +21,8 @@ const install = options =>
 
     if (options.starterkits && Array.isArray(options.starterkits)) {
       const starterkits = yield Promise.all(
-        options.starterkits.map(starterkit =>
-          wrapAsync(function*() {
+        options.starterkits.map((starterkit) =>
+          wrapAsync(function* () {
             spinner.text = `⊙ patternlab → Installing starterkit: ${starterkit}`;
             return yield installStarterkit(
               {
@@ -42,8 +42,8 @@ const install = options =>
     }
     if (options.plugins && Array.isArray(options.plugins)) {
       const plugins = yield Promise.all(
-        options.plugins.map(plugin =>
-          wrapAsync(function*() {
+        options.plugins.map((plugin) =>
+          wrapAsync(function* () {
             return yield installPlugin(
               {
                 name: plugin,

packages/cli/bin/cli-actions/serve.js

@@ -3,8 +3,8 @@ const resolveConfig = require('../resolve-config');
 const servePatterns = require('../serve');
 const wrapAsync = require('../utils').wrapAsync;
 
-const serve = options =>
-  wrapAsync(function*() {
+const serve = (options) =>
+  wrapAsync(function* () {
     const config = yield resolveConfig(options.parent.config);
     servePatterns(config, options);
   });