@@ -214,7 +214,7 @@ void MainWindow::checkPcb2gcodeVersion()
214214 QStringList versionSplit = pcb2gcodeVersion.split (' .' );
215215 QVector<int > versionNumbers;
216216
217- for (const QString& str : versionSplit)
217+ foreach (const QString& str, versionSplit)
218218 {
219219 versionNumbers.append (str.toInt ());
220220 }
@@ -323,11 +323,11 @@ void MainWindow::generateImages()
323323
324324 arguments += getCmdLineArguments ();
325325
326- for (QString& option : arguments)
326+ for (QStringList::iterator i = arguments. begin (); i != arguments. end (); i++ )
327327 {
328- if (option. startsWith (" --output-dir" ))
328+ if (i-> startsWith (" --output-dir" ))
329329 {
330- option = " --output-dir=" + imagesFolder;
330+ *i = " --output-dir=" + imagesFolder;
331331 found_output_dir = true ;
332332 break ;
333333 }
@@ -347,6 +347,19 @@ void MainWindow::generateImages()
347347 pcb2gcodeImageProcess.start (PCB2GCODE_EXECUTABLE, arguments, QProcess::ReadOnly);
348348}
349349
350+ void MainWindow::addImageFile (const QDir& dir, const QString& item, const QString& filename)
351+ {
352+ foreach (const QFileInfo& image, dir.entryInfoList ())
353+ {
354+ if (image.baseName ().contains (filename))
355+ {
356+ imagesFilename.append (image.absoluteFilePath ());
357+ ui->imageComboBox ->addItem (item);
358+ break ;
359+ }
360+ }
361+ }
362+
350363void MainWindow::imagesGenerated (int exitCode, QProcess::ExitStatus exitStatus)
351364{
352365 loadingIcon.stop ();
@@ -356,19 +369,6 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
356369 {
357370 QDir dir (currentImagesFolder);
358371
359- auto addItem = [&] (QString item, QString filename)
360- {
361- for (const QFileInfo& image : dir.entryInfoList ())
362- {
363- if (image.baseName ().contains (filename))
364- {
365- imagesFilename.append (image.absoluteFilePath ());
366- ui->imageComboBox ->addItem (item);
367- break ;
368- }
369- }
370- };
371-
372372 if (vectorial)
373373 dir.setNameFilters (QStringList () << " *.svg" );
374374 else
@@ -379,17 +379,17 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
379379 imagesFilename.clear ();
380380 ui->imageComboBox ->clear ();
381381
382- addItem ( tr (" Processed front" ), " processed_front" );
383- addItem ( tr (" Processed back" ), " processed_back" );
384- addItem ( tr (" Processed outline" ), " processed_outline" );
385- addItem ( tr (" Traced front" ), " traced_front" );
386- addItem ( tr (" Traced back" ), " traced_back" );
387- addItem ( tr (" Masked front" ), " masked_front" );
388- addItem ( tr (" Masked back" ), " masked_back" );
389- addItem ( tr (" Input front" ), " original_front" );
390- addItem ( tr (" Input back" ), " original_back" );
391- addItem ( tr (" Input drill" ), " original_drill" );
392- addItem ( tr (" Input outline" ), fillOutline ? " outline_filled" : " original_outline" );
382+ addImageFile (dir, tr (" Processed front" ), " processed_front" );
383+ addImageFile (dir, tr (" Processed back" ), " processed_back" );
384+ addImageFile (dir, tr (" Processed outline" ), " processed_outline" );
385+ addImageFile (dir, tr (" Traced front" ), " traced_front" );
386+ addImageFile (dir, tr (" Traced back" ), " traced_back" );
387+ addImageFile (dir, tr (" Masked front" ), " masked_front" );
388+ addImageFile (dir, tr (" Masked back" ), " masked_back" );
389+ addImageFile (dir, tr (" Input front" ), " original_front" );
390+ addImageFile (dir, tr (" Input back" ), " original_back" );
391+ addImageFile (dir, tr (" Input drill" ), " original_drill" );
392+ addImageFile (dir, tr (" Input outline" ), fillOutline ? " outline_filled" : " original_outline" );
393393 }
394394 else
395395 {
@@ -422,7 +422,7 @@ void MainWindow::showImage(QString image)
422422{
423423 const bool wasEmpty = scene.items ().isEmpty ();
424424
425- for (QGraphicsItem *item : scene.items ())
425+ foreach (QGraphicsItem *item, scene.items ())
426426 {
427427 scene.removeItem (item);
428428 delete item;
@@ -925,7 +925,7 @@ void MainWindow::clearImages()
925925 dir.setNameFilters (QStringList () << " *.*" );
926926 dir.setFilter (QDir::Files);
927927
928- for (const QString& dirFile : dir.entryList ())
928+ foreach (const QString& dirFile, dir.entryList ())
929929 {
930930 dir.remove (dirFile);
931931 }
0 commit comments