Commit 92290c5
committed
NotesApi: fix createMergeRequestNote() API breakage introduced in 5.8.0
Even when the new `created_at` and `internal` arguments are marked as
"optional", that doesn't mean one can simply omit them from argument
list. This means `createMergeRequestNote()`'s function signature has
been changed, which is a breaking change which happens without major
version bump.
So add a wrapper function with the old signature that calls the new
signature, which restores compatibility to un-migrated code.
IMO this change is not needed for 6.x.x line, as that can be seen as
major update and API breakage is fine that way. Although, I'll admit
that with 5.8.0 released over a year ago, I'm not sure if this still
matters anymore...
Fixes: 60259a6 ("Add attributes "created_at", "internal" for NotesApi commits and DiscussionApi merge requests (gitlab4j#1194)")1 parent 89aeda9 commit 92290c5
1 file changed
+16
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
527 | 543 | | |
528 | 544 | | |
529 | 545 | | |
| |||
0 commit comments