fix: don't assume new log_level setting was defaulted (#831)

jaredhendrickson13 · web-flow · commit 10646587f3e6 · 2026-01-19T10:30:28.000-07:00
diff --git a/pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/BaseTraits.inc b/pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/BaseTraits.inc
@@ -53,7 +53,8 @@ trait BaseTraits {
 
         # If the log level has not been set yet, obtain it
         if (!isset(self::$__log_level)) {
-            self::$__log_level = constant(RESTAPISettings::get_pkg_config()['log_level']) ?? 4;
+            $log_lvl_cfg = RESTAPISettings::get_pkg_config()['log_level'] ?? 'LOG_WARNING';
+            self::$__log_level = constant($log_lvl_cfg);
         }
 
         # Do not log if the incoming level is higher than the configured log level

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ trait BaseTraits {`
`53`	`53`
`54`	`54`	`# If the log level has not been set yet, obtain it`
`55`	`55`	`if (!isset(self::$__log_level)) {`
`56`		`- self::$__log_level = constant(RESTAPISettings::get_pkg_config()['log_level']) ?? 4;`
	`56`	`+ $log_lvl_cfg = RESTAPISettings::get_pkg_config()['log_level'] ?? 'LOG_WARNING';`
	`57`	`+ self::$__log_level = constant($log_lvl_cfg);`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`# Do not log if the incoming level is higher than the configured log level`