fix: do not check for updates inline for non-update UI pages

Fixes an issue that could result in a crash if release updates could not be determined when loading the Settings UI page.

Author: jaredhendrickson13

pfSense-pkg-API/files/usr/local/www/api/index.php

@@ -23,8 +23,7 @@
 include('head.inc');
 echo "<link rel='stylesheet' href='/css/api/api.css'/>";
 echo "<script type='application/javascript' src='/js/api.js'></script>";
-$update_tab = (APISystemAPIVersionRead::is_update_available()) ? "Update (New Release Available)" : "Update";
-$tab_array = [[gettext("Settings"), true, "/api/"], [gettext("Documentation"), false, "/api/documentation/"], [gettext($update_tab), false, "/api/update/"]];
+$tab_array = [[gettext("Settings"), true, "/api/"], [gettext("Documentation"), false, "/api/documentation/"], [gettext("Update"), false, "/api/update/"]];
 display_top_tabs($tab_array, true);    # Ensure the tabs are written to the top of page
 
 # Variables

pfSense-pkg-API/files/usr/local/www/api/update/index.php

@@ -25,8 +25,7 @@
 echo "<script type='application/javascript' src='/js/api.js'></script>";
 $pkg_index = APITools\get_api_config()[0];
 $pkg_config = APITools\get_api_config()[1];
-$update_tab = (APISystemAPIVersionRead::is_update_available()) ? "Update (New Release Available)" : "Update";
-$tab_array = [[gettext("Settings"), false, "/api/"], [gettext("Documentation"), false, "/api/documentation/"], [gettext($update_tab), true, "/api/update/"]];
+$tab_array = [[gettext("Settings"), false, "/api/"], [gettext("Documentation"), false, "/api/documentation/"], [gettext("Update"), true, "/api/update/"]];
 display_top_tabs($tab_array, true);    # Ensure the tabs are written to the top of page
 
 # Save changes before loading version information, so the changes will be loaded correctly afterward.