feat: allow FreeRADIUSUsers to be updated and replaced

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesFreeRADIUSUserEndpoint.inc

@@ -18,7 +18,7 @@ class ServicesFreeRADIUSUserEndpoint extends Endpoint {
         $this->url = '/api/v2/services/freeradius/user';
         $this->model_name = 'FreeRADIUSUser';
         $this->many = false;
-        $this->request_method_options = ['GET', 'POST', 'DELETE'];
+        $this->request_method_options = ['GET', 'POST', 'PATCH', 'DELETE'];
 
         # Construct the parent Endpoint object
         parent::__construct();

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesFreeRADIUSUsersEndpoint.inc

@@ -18,7 +18,7 @@ class ServicesFreeRADIUSUsersEndpoint extends Endpoint {
         $this->url = '/api/v2/services/freeradius/users';
         $this->model_name = 'FreeRADIUSUser';
         $this->many = true;
-        $this->request_method_options = ['GET', 'DELETE'];
+        $this->request_method_options = ['GET', 'PUT', 'DELETE'];
 
         # Construct the parent Endpoint object
         parent::__construct();

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/FreeRADIUSUser.inc

@@ -60,7 +60,7 @@ class FreeRADIUSUser extends Model {
         $this->motp_enable = new BooleanField(
             required: true,
             indicates_true: 'on',
-            indicates_false: 'off',
+            indicates_false: '',
             internal_name: 'varusersmotpenable',
             help_text: 'Enable or disable the use of Mobile One-Time Password (MOTP) for this user.',
         );
@@ -135,16 +135,9 @@ class FreeRADIUSUser extends Model {
     }
 
     /**
-     * Apply the creation of this User.
+     * Apply the changes made to this Model to the FreeRADIUS configuration.
      */
-    public function apply_create(): void {
-        freeradius_users_resync();
-    }
-
-    /**
-     * Apply the deletion of this User.
-     */
-    public function apply_delete(): void {
+    public function apply(): void {
         freeradius_users_resync();
     }
 }