fix(RESTAPISettings): don't init models in choices callable #764

This commit addresses an issue where loading the RESTAPISettings `override_sensitive_fields` choices would loop through all model classes and allowed initialization of certain models, which could cause unexpected errors on Form pages. Going forward this callable will no longer allow models to automatically initialize.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/RESTAPISettings.inc

@@ -235,7 +235,7 @@ class RESTAPISettings extends Model {
 
         # Format choices so they include the class's verbose name as the choice's verbose name
         foreach (get_classes_from_namespace(namespace: '\\RESTAPI\\Models\\') as $model_class) {
-            $model = new $model_class();
+            $model = new $model_class(skip_init: true);
             foreach ($model->get_fields() as $field) {
                 if ($model->$field->sensitive) {
                     $choices[$model->get_class_shortname() . ':' . $field] =