fix: handle inconsistent delimiter for SystemStatus cpu_load_average #716

This commit fixes a bug where pfSense's get_load_average() function returns a load average string that changes based on the system's language setting. Previously, the numbers in the load average string might be separated by just a space, or by a comma and a space. This inconsistency caused an error when the API tried to convert that string into a usable array of values. Now, we're ensuring the load average string is always delimited by a single space, no matter what language pfSense is using. This prevents the logic error and ensures the API can correctly convert the load average to its intended array representation.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/SystemStatus.inc

@@ -116,7 +116,7 @@ class SystemStatus extends Model {
             allow_null: true,
             read_only: true,
             many: true,
-            delimiter: ', ',
+            delimiter: ' ',
             help_text: 'The CPU load averages. The first value represents the load average for the last minute, the ' .
                 'second value represents the load average for the last 5 minutes, and the third value represents the ' .
                 'load average for the last 15 minutes.',
@@ -181,7 +181,7 @@ class SystemStatus extends Model {
             'mds_mitigation' => get_single_sysctl('hw.mds_disable_state'),
             'temp_c' => $this->get_system_temp(),
             'temp_f' => $this->get_system_temp(as_fahrenheit: true),
-            'cpu_load_avg' => get_load_average(),
+            'cpu_load_avg' => $this->get_cpu_load_average(),
             'cpu_count' => get_single_sysctl('hw.ncpu'),
             'cpu_usage' => $this->get_cpu_usage(),
             'mbuf_usage' => $this->get_mbuf_usage(),
@@ -223,6 +223,24 @@ class SystemStatus extends Model {
         return $as_fahrenheit ? $temp * 1.8 + 32 : $temp;
     }
 
+    /**
+     * Obtains the CPU load average. This method is responsible for obtaining the raw load average string from pfSense
+     * and ensuring it is formatted correctly before the cpu_load_average field splits it into an array.
+     * @return string|null The CPU load average as a string or null if it could not be obtained.
+     */
+    private function get_cpu_load_average(): ?string {
+        # Obtain the load average using pfSense's get_load_average() function
+        $load_avg = get_load_average();
+
+        # The system language may affect the load average's delimiter (missing a comma in some languages)
+        # ensure values are only ever separated by a single space (no commas). #716
+        if (str_contains(", ", $load_avg)) {
+            $load_avg = str_replace(', ', ' ', $load_avg);
+        }
+
+        return $load_avg ?? null;
+    }
+
     /**
      * Determines approximate CPU usage using the last minute load average.
      * @return float|null The CPU usage as a whole percentage.