test(UserGroup): ensure we can update and read large user groups within 10 seconds

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsUserGroupTestCase.inc

@@ -163,4 +163,48 @@ class APIModelsUserGroupTestCase extends TestCase {
             },
         );
     }
+
+    /**
+     * Ensures UserGroups remain readable even when many users are assigned to a group. This tests for performance
+     * issues identified in GitHub issue #779.
+     */
+    public function test_read_performance_with_many_members(): void
+    {
+        # Mock creating many users by direct config assignment
+        foreach (range(1, 1000) as $idx) {
+            global $config;
+            $config['system']['user'][] = [
+                'name' => "testuser$idx",
+                'uid' => 3000 + $idx,
+            ];
+        }
+
+        # Create a UserGroup with many members
+        $user_group = new UserGroup(
+            name: 'biggroup',
+            scope: 'local',
+            member: [],
+        );
+        $user_group->create();
+
+        # Perform an update that maps all created users to our group and track its time
+        $start_time = time();
+        $user_group->member->value = array_map(fn($i) => "testuser$i", range(1, 1000));
+        $user_group->update();
+        $end_time = time();
+        $duration = $end_time - $start_time;
+
+        # Ensure the update took less than 10 seconds
+        $this->assert_is_less_than($duration, 5);
+
+        # Ensure we can read all user groups within 10 seconds
+        $start_time = time();
+        UserGroup::read_all();
+        $end_time = time();
+        $duration = $end_time - $start_time;
+        $this->assert_is_less_than($duration, 5);
+
+        # Clean up the user group
+        $user_group->delete();
+    }
 }