fix(FirewallAlias): fix 'detail' auto-generation

This commit fixes an issue that prevented the 'detail' field values from auto populating when not provided.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/FirewallAlias.inc

@@ -131,12 +131,13 @@ class FirewallAlias extends Model {
     }
 
     /**
-     * Adds custom validation to `detail` field
-     * @param string $detail The incoming value to be validated.
+     * Adds extra validation to the entire model. This is primarily used to ensure the `detail` field automatically
+     * creates entries to match the number of `address` entries if there are not enough, or throws an error if there
+     * are too many.
      * @returns string The validated value to be set.
-     * @throws ValidationError When the `detail` value is invalid.
+     * @throws ValidationError When the `detail` array has too many entries.
      */
-    public function validate_detail(string $detail): string {
+    public function validate_extra(): void {
         # Throw an error if there are more `detail` items than `address` items
         if (count($this->detail->value) > count($this->address->value)) {
             throw new ValidationError(
@@ -149,8 +150,6 @@ class FirewallAlias extends Model {
         while (count($this->detail->value) < count($this->address->value)) {
             $this->detail->value[] = 'Entry added ' . date('r');
         }
-
-        return $detail;
     }
 
     /**