Work with the client interface instead of concrete implementation

Author: WyriHaximus

src/Factory.php

@@ -4,7 +4,7 @@
 
 use ApiClients\Foundation\Hydrator\Factory as HydratorFactory;
 use ApiClients\Foundation\Hydrator\Hydrator;
-use ApiClients\Foundation\Transport\Client as TransportClient;
+use ApiClients\Foundation\Transport\ClientInterface;
 use ApiClients\Foundation\Transport\Factory as TransportFactory;
 use ApiClients\Tools\CommandBus\CommandBusInterface;
 use ApiClients\Tools\CommandBus\Factory as CommandBusFactory;
@@ -30,7 +30,7 @@ private static function createContainer(LoopInterface $loop, array $options): Co
 
         $container->addDefinitions([
             LoopInterface::class => $loop,
-            TransportClient::class => function (ContainerInterface $container, LoopInterface $loop) use ($options) {
+            ClientInterface::class => function (ContainerInterface $container, LoopInterface $loop) use ($options) {
                 return self::createTransport($container, $loop, $options);
             },
             Hydrator::class => function (ContainerInterface $container) use ($options) {
@@ -49,7 +49,7 @@ private static function createTransport(
         ContainerInterface $container,
         LoopInterface $loop,
         array $options = []
-    ): TransportClient {
+    ): ClientInterface {
         if (!isset($options[Options::TRANSPORT_OPTIONS])) {
             throw new InvalidArgumentException('Missing Transport options');
         }

tests/FactoryTest.php

@@ -6,6 +6,7 @@
 use ApiClients\Foundation\Factory;
 use ApiClients\Foundation\Hydrator\Hydrator;
 use ApiClients\Foundation\Transport\Client as TransportClient;
+use ApiClients\Foundation\Transport\ClientInterface;
 use ApiClients\Foundation\Transport\Options as TransportOptions;
 use ApiClients\Foundation\Options;
 use ApiClients\Tools\TestUtilities\TestCase;
@@ -47,7 +48,7 @@ public function testCreate()
         $this->assertInstanceOf(LoopInterface::class, $container->get(LoopInterface::class));
         $this->assertSame($loop, $container->get(LoopInterface::class));
         $this->assertInstanceOf(Hydrator::class, $container->get(Hydrator::class));
-        $this->assertInstanceOf(TransportClient::class, $container->get(TransportClient::class));
+        $this->assertInstanceOf(TransportClient::class, $container->get(ClientInterface::class));
         $this->assertInstanceOf(\stdClass::class, $container->get(\stdClass::class));
         $this->assertSame($stdClass, $container->get(\stdClass::class));
         $this->assertSame('bar', $container->get(\stdClass::class)->foo);
@@ -87,6 +88,6 @@ public function testCreateMissingTransportOptions()
             [
                 Options::HYDRATOR_OPTIONS => [],
             ]
-        )->getContainer()->get(TransportClient::class);
+        )->getContainer()->get(ClientInterface::class);
     }
 }