lexbor: Cherry pick "Core: Reset length in lexbor_str_destroy()"

see lexbor/lexbor@1bc9944

Fixes #19979

Author: TimWolla

NEWS

@@ -6,7 +6,10 @@ PHP                                                                        NEWS
   . Fixed segfault in function JIT due to NAN to bool warning. (Girgias)
 
 - URI:
-  . Fixed Uri\WhatWg\Url::withPort() when an invalid value is passed. (timwolla)
+  . Fixed Uri\WhatWg\Url::withPort() when an invalid value is passed.
+    (timwolla)
+  . Fixed Uri\WhatWg\Url::parse() when resolving a relative URL
+    against a base URL with query or fragment. (timwolla)
 
 - SOAP:
   . Fixed bug GH-19773 (SIGSEGV due to uninitialized soap_globals->lang_en).

ext/lexbor/lexbor/core/str.c

@@ -80,6 +80,7 @@ lexbor_str_destroy(lexbor_str_t *str, lexbor_mraw_t *mraw, bool destroy_obj)
     }
 
     if (str->data != NULL) {
+        lexbor_str_clean(str);
         str->data = lexbor_mraw_free(mraw, str->data);
     }
 

ext/uri/tests/gh19979.phpt

@@ -0,0 +1,28 @@
+--TEST--
+GH-19979: Zend/zend_string.h:191:24: runtime error: null pointer passed as argument 2, which is declared to never be null
+--FILE--
+<?php
+
+$baseUrl = \Uri\WhatWg\Url::parse('https://example.com/path?query');
+var_dump(\Uri\WhatWg\Url::parse('relative', $baseUrl));
+
+?>
+--EXPECTF--
+object(Uri\WhatWg\Url)#%d (8) {
+  ["scheme"]=>
+  string(5) "https"
+  ["username"]=>
+  NULL
+  ["password"]=>
+  NULL
+  ["host"]=>
+  string(11) "example.com"
+  ["port"]=>
+  NULL
+  ["path"]=>
+  string(9) "/relative"
+  ["query"]=>
+  NULL
+  ["fragment"]=>
+  NULL
+}