phar: Avoid string duplication just for error message, use truncation formatting string (#20229)

ndossche · web-flow · commit 40b3f884260b · 2025-10-20T20:31:16.000+02:00
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
@@ -4315,10 +4315,7 @@ PHP_METHOD(Phar, extractTo)
 	}
 
 	if (ZSTR_LEN(path_to) >= MAXPATHLEN) {
-		char *tmp = estrndup(ZSTR_VAL(path_to), 50);
-		/* truncate for error message */
-		zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0, "Cannot extract to \"%s...\", destination directory is too long for filesystem", tmp);
-		efree(tmp);
+		zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0, "Cannot extract to \"%.50s...\", destination directory is too long for filesystem", ZSTR_VAL(path_to));
 		RETURN_THROWS();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4315,10 +4315,7 @@ PHP_METHOD(Phar, extractTo)`
`4315`	`4315`	`}`
`4316`	`4316`
`4317`	`4317`	`if (ZSTR_LEN(path_to) >= MAXPATHLEN) {`
`4318`		`- char *tmp = estrndup(ZSTR_VAL(path_to), 50);`
`4319`		`- /* truncate for error message */`
`4320`		`- zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0, "Cannot extract to \"%s...\", destination directory is too long for filesystem", tmp);`
`4321`		`- efree(tmp);`
	`4318`	`+ zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0, "Cannot extract to \"%.50s...\", destination directory is too long for filesystem", ZSTR_VAL(path_to));`
`4322`	`4319`	`RETURN_THROWS();`
`4323`	`4320`	`}`
`4324`	`4321`