Test all paths

Author: iluuu1994

ext/reflection/php_reflection.c

@@ -6783,6 +6783,10 @@ ZEND_METHOD(ReflectionProperty, isWritable)
 		if (!(ce->ce_flags & ZEND_ACC_NO_DYNAMIC_PROPERTIES)) {
 			RETURN_TRUE;
 		}
+		/* This path is effectively unreachable, but theoretically possible for
+		 * two internal classes where ZEND_ACC_NO_DYNAMIC_PROPERTIES is only
+		 * added to the subclass, in which case a ReflectionProperty can be
+		 * constructed on the parent class, and then tested on the subclass. */
 handle_magic_set:
 		RETURN_BOOL(ce->__set);
 	}

ext/reflection/tests/ReflectionProperty_isReadable_invalid_scope.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Test ReflectionProperty::isReadable() invalid scope
+--FILE--
+<?php
+
+class A {
+    public $prop;
+}
+
+$r = new ReflectionProperty('A', 'prop');
+
+try {
+    $r->isReadable('B', null);
+} catch (Error $e) {
+    echo $e::class, ': ', $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Error: Class "B" not found

ext/reflection/tests/ReflectionProperty_isReadable_unrelated_object.phpt

@@ -0,0 +1,36 @@
+--TEST--
+Test ReflectionProperty::isReadable() unrelated object
+--FILE--
+<?php
+
+class A {
+}
+
+class B extends A {
+    public $prop;
+}
+
+class C extends B {}
+
+class D {}
+
+function test($obj) {
+    $r = new ReflectionProperty('B', 'prop');
+    try {
+        var_dump($r->isReadable(null, $obj));
+    } catch (Exception $e) {
+        echo $e::class, ': ', $e->getMessage(), "\n";
+    }
+}
+
+test(new A);
+test(new B);
+test(new C);
+test(new D);
+
+?>
+--EXPECT--
+ReflectionException: Given object is not an instance of the class this property was declared in
+bool(true)
+bool(true)
+ReflectionException: Given object is not an instance of the class this property was declared in

ext/reflection/tests/ReflectionProperty_isReadable_visibility.phpt

@@ -9,20 +9,32 @@ class B extends A {
     public $a;
     protected $b;
     private $c;
-    public protected(set) int $d;
+    public protected(set) int $d = 42;
 }
 
 class C extends B {}
 
+class D extends C {
+    public function __get($name) {}
+}
+
+class E extends D {
+    private $f;
+
+    public function __isset($name) {
+        return $name === 'f';
+    }
+}
+
 $test = static function ($scope) {
     $rc = new ReflectionClass(B::class);
     foreach ($rc->getProperties() as $rp) {
         echo $rp->getName() . ' from ' . ($scope ?? 'global') . ': ';
-        var_dump($rp->isReadable($scope, null));
+        var_dump($rp->isReadable($scope, $scope && $scope !== 'A' ? new $scope : null));
     }
 };
 
-foreach (['A', 'B', 'C'] as $scope) {
+foreach (['A', 'B', 'C', 'D', 'E'] as $scope) {
     $test($scope);
 }
 $test(null);
@@ -41,6 +53,14 @@ a from C: bool(true)
 b from C: bool(true)
 c from C: bool(false)
 d from C: bool(true)
+a from D: bool(true)
+b from D: bool(true)
+c from D: bool(true)
+d from D: bool(true)
+a from E: bool(true)
+b from E: bool(true)
+c from E: bool(false)
+d from E: bool(true)
 a from global: bool(true)
 b from global: bool(false)
 c from global: bool(false)

ext/reflection/tests/ReflectionProperty_isWritable_invalid_scope.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Test ReflectionProperty::isWritable() invalid scope
+--FILE--
+<?php
+
+class A {
+    public $prop;
+}
+
+$r = new ReflectionProperty('A', 'prop');
+
+try {
+    $r->isWritable('B', null);
+} catch (Error $e) {
+    echo $e::class, ': ', $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Error: Class "B" not found

ext/reflection/tests/ReflectionProperty_isWritable_unrelated_object.phpt

@@ -0,0 +1,36 @@
+--TEST--
+Test ReflectionProperty::isWritable() unrelated object
+--FILE--
+<?php
+
+class A {
+}
+
+class B extends A {
+    public $prop;
+}
+
+class C extends B {}
+
+class D {}
+
+function test($obj) {
+    $r = new ReflectionProperty('B', 'prop');
+    try {
+        var_dump($r->isWritable(null, $obj));
+    } catch (Exception $e) {
+        echo $e::class, ': ', $e->getMessage(), "\n";
+    }
+}
+
+test(new A);
+test(new B);
+test(new C);
+test(new D);
+
+?>
+--EXPECT--
+ReflectionException: Given object is not an instance of the class this property was declared in
+bool(true)
+bool(true)
+ReflectionException: Given object is not an instance of the class this property was declared in

ext/reflection/tests/ReflectionProperty_isWritable_visibility.phpt

@@ -16,17 +16,22 @@ class B extends A {
 
 class C extends B {}
 
+class D extends C {
+    public function __set($name, $value) {}
+}
+
 $test = static function ($scope) {
     $rc = new ReflectionClass(B::class);
     foreach ($rc->getProperties() as $rp) {
         echo $rp->getName() . ' from ' . ($scope ?? 'global') . ': ';
-        var_dump($rp->isWritable($scope, null));
+        var_dump($rp->isWritable($scope, $scope && $scope !== 'A' ? new $scope : null));
     }
 };
 
 $test('A');
 $test('B');
 $test('C');
+$test('D');
 $test(null);
 
 ?>
@@ -49,6 +54,12 @@ c from C: bool(false)
 d from C: bool(false)
 e from C: bool(true)
 f from C: bool(true)
+a from D: bool(true)
+b from D: bool(true)
+c from D: bool(true)
+d from D: bool(false)
+e from D: bool(true)
+f from D: bool(true)
 a from global: bool(true)
 b from global: bool(false)
 c from global: bool(false)