Implement CallWithDeprecatedIniOptionRule

Author: staabm

rules.neon

@@ -22,6 +22,7 @@ rules:
 	- PHPStan\Rules\Deprecations\CallToDeprecatedFunctionRule
 	- PHPStan\Rules\Deprecations\CallToDeprecatedMethodRule
 	- PHPStan\Rules\Deprecations\CallToDeprecatedStaticMethodRule
+	- PHPStan\Rules\Deprecations\CallWithDeprecatedIniOptionRule
 	- PHPStan\Rules\Deprecations\FetchingClassConstOfDeprecatedClassRule
 	- PHPStan\Rules\Deprecations\FetchingDeprecatedConstRule
 	- PHPStan\Rules\Deprecations\ImplementationOfDeprecatedInterfaceRule

src/Rules/Deprecations/CallWithDeprecatedIniOptionRule.php

@@ -0,0 +1,111 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Deprecations;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
+use PHPStan\Analyser\Scope;
+use PHPStan\Broker\FunctionNotFoundException;
+use PHPStan\Php\PhpVersion;
+use PHPStan\Reflection\ReflectionProvider;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use function count;
+use function in_array;
+use function sprintf;
+use function strtolower;
+
+/**
+ * @implements Rule<FuncCall>
+ */
+class CallWithDeprecatedIniOptionRule implements Rule
+{
+
+	private const INI_FUNCTIONS = [
+		'ini_get',
+		'ini_set',
+		'ini_alter',
+		'ini_restore',
+	];
+
+	private const DEPRECATED_OPTIONS = [
+		'8.3' => [
+			'assert.active',
+			'assert.exception',
+			'assert.bail',
+			'assert.warning',
+		],
+	];
+
+	private ReflectionProvider $reflectionProvider;
+
+	private DeprecatedScopeHelper $deprecatedScopeHelper;
+
+	private PhpVersion $phpVersion;
+
+	public function __construct(
+		ReflectionProvider $reflectionProvider,
+		DeprecatedScopeHelper $deprecatedScopeHelper,
+		PhpVersion $phpVersion
+	)
+	{
+		$this->reflectionProvider = $reflectionProvider;
+		$this->deprecatedScopeHelper = $deprecatedScopeHelper;
+		$this->phpVersion = $phpVersion;
+	}
+
+	public function getNodeType(): string
+	{
+		return FuncCall::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		if ($this->deprecatedScopeHelper->isScopeDeprecated($scope)) {
+			return [];
+		}
+
+		if (!($node->name instanceof Name)) {
+			return [];
+		}
+
+		if (count($node->getArgs()) < 1) {
+			return [];
+		}
+
+		try {
+			$function = $this->reflectionProvider->getFunction($node->name, $scope);
+		} catch (FunctionNotFoundException $e) {
+			// Other rules will notify if the function is not found
+			return [];
+		}
+
+		if (!in_array(strtolower($function->getName()), self::INI_FUNCTIONS, true)) {
+			return [];
+		}
+
+		$phpVersion = $this->phpVersion->getMajorVersionId() . '.' . $this->phpVersion->getMinorVersionId();
+		if (!isset(self::DEPRECATED_OPTIONS[$phpVersion])) {
+			return [];
+		}
+
+		$iniType = $scope->getType($node->getArgs()[0]->value);
+		foreach ($iniType->getConstantStrings() as $string) {
+			if (!in_array($string->getValue(), self::DEPRECATED_OPTIONS[$phpVersion], true)) {
+				continue;
+			}
+
+			return [
+				RuleErrorBuilder::message(sprintf(
+					"Call to function %s() with deprecated option '%s'.",
+					$function->getName(),
+					$string->getValue(),
+				))->identifier('function.deprecated')->build(),
+			];
+		}
+
+		return [];
+	}
+
+}

tests/Rules/Deprecations/CallWithDeprecatedIniOptionRuleTest.php

@@ -0,0 +1,47 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Deprecations;
+
+use PHPStan\Php\PhpVersion;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
+
+/**
+ * @extends RuleTestCase<CallWithDeprecatedIniOptionRule>
+ */
+class CallWithDeprecatedIniOptionRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new CallWithDeprecatedIniOptionRule(
+			$this->createReflectionProvider(),
+			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver()]),
+			self::getContainer()->getByType(PhpVersion::class),
+		);
+	}
+
+	public function testRule(): void
+	{
+		$expectedErrors = [];
+		if (PHP_VERSION_ID >= 80300) {
+			$expectedErrors = [
+				[
+					"Call to function ini_set() with deprecated option 'assert.active'.",
+					11,
+				],
+				[
+					"Call to function ini_get() with deprecated option 'assert.active'.",
+					12,
+				],
+			];
+		}
+
+		$this->analyse(
+			[__DIR__ . '/data/call-with-deprecation-ini-option.php'],
+			$expectedErrors,
+		);
+	}
+
+}

tests/Rules/Deprecations/data/call-with-deprecation-ini-option.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace CallWithDeprecatedIniOption;
+
+function doFooBar(): void {
+	var_dump(ini_set('memory_limit', '2048M'));
+	var_dump(ini_get('memory_limit'));
+}
+
+function doFoo(): void {
+	var_dump(ini_set('assert.active', false));
+	var_dump(ini_get('assert.active'));
+}
+
+/** @deprecated */
+function inDeprecatedFunction(): void {
+	var_dump(ini_set('assert.active', false));
+	var_dump(ini_get('assert.active'));
+}