Fixes

Author: janedbal

src/Rules/Deprecations/DefaultDeprecationProvider.php

@@ -23,18 +23,9 @@ public function getDeprecation($reflection): ?Deprecation
 				: null;
 		}
 
-		if (
-			$reflection instanceof ConstantReflection
-			|| $reflection instanceof EnumCaseReflection
-			|| $reflection instanceof ExtendedPropertyReflection
-			|| $reflection instanceof ExtendedMethodReflection
-			|| $reflection instanceof FunctionReflection
-		) {
-			return $reflection->isDeprecated()->yes()
-				? Deprecation::create()->withDescription($reflection->getDeprecatedDescription())
-				: null;
-		}
-
-		return null;
+		return $reflection->isDeprecated()->yes()
+			? Deprecation::create()->withDescription($reflection->getDeprecatedDescription())
+			: null;
 	}
+
 }

src/Rules/Deprecations/Deprecation.php

@@ -2,12 +2,6 @@
 
 namespace PHPStan\Rules\Deprecations;
 
-use PHPStan\BetterReflection\Reflection\ReflectionClass;
-use PHPStan\BetterReflection\Reflection\ReflectionFunction;
-use PHPStan\BetterReflection\Reflection\ReflectionMethod;
-use PHPStan\BetterReflection\Reflection\ReflectionProperty;
-use PHPStan\Reflection\PropertyReflection;
-
 /**
  * @api
  */
@@ -20,11 +14,13 @@ private function __construct()
 	{
 	}
 
-	public static function create(): self {
+	public static function create(): self
+	{
 		return new self();
 	}
 
-	public function withDescription(?string $description): self {
+	public function withDescription(?string $description): self
+	{
 		$clone = clone $this;
 		$clone->description = $description;
 		return $clone;

src/Rules/Deprecations/DeprecationProvider.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Rules\Deprecations;
 

tests/Rules/Deprecations/CallWithDeprecatedIniOptionRuleTest.php

@@ -20,7 +20,6 @@ protected function getRule(): Rule
 			$this->createReflectionProvider(),
 			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver($deprecationHelper)]),
 			self::getContainer()->getByType(PhpVersion::class),
-			$deprecationHelper,
 		);
 	}
 

tests/Rules/Deprecations/TypeHintDeprecatedInClassMethodSignatureRuleTest.php

@@ -17,7 +17,6 @@ protected function getRule(): Rule
 		return new TypeHintDeprecatedInClassMethodSignatureRule(
 			new DeprecatedClassHelper($this->createReflectionProvider(), $deprecationHelper),
 			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver($deprecationHelper)]),
-			$deprecationHelper,
 		);
 	}
 

tests/Rules/Deprecations/TypeHintDeprecatedInClosureSignatureRuleTest.php

@@ -17,7 +17,6 @@ protected function getRule(): Rule
 		return new TypeHintDeprecatedInClosureSignatureRule(
 			new DeprecatedClassHelper($this->createReflectionProvider(), $deprecationHelper),
 			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver($deprecationHelper)]),
-			$deprecationHelper,
 		);
 	}
 

tests/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRuleTest.php

@@ -17,7 +17,6 @@ protected function getRule(): Rule
 		return new TypeHintDeprecatedInFunctionSignatureRule(
 			new DeprecatedClassHelper($this->createReflectionProvider(), $deprecationHelper),
 			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver($deprecationHelper)]),
-			$deprecationHelper,
 		);
 	}