Constants deprecation depends on Scope->getPhpVersion()

Author: staabm

tests/Rules/Deprecations/FetchingDeprecatedConstRuleTest.php

@@ -59,4 +59,21 @@ public function testFetchingDeprecatedConst(): void
 		);
 	}
 
+	public function testEstrictWithVersionGuard(): void
+	{
+		require_once __DIR__ . '/data/bug-162.php';
+		$this->analyse(
+			[__DIR__ . '/data/bug-162.php'],
+			[
+				[
+					'Use of constant E_STRICT is deprecated.',
+					7
+				],
+				[
+					'Use of constant E_STRICT is deprecated.',
+					18
+				],
+			],
+		);
+	}
 }

tests/Rules/Deprecations/data/bug-162.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug162;
+
+function foo(int $errno):void {
+	if (PHP_VERSION_ID >= 80400) {
+		if (E_STRICT === $errno) {
+
+		}
+	}
+
+	if (PHP_VERSION_ID < 80400) {
+		if (E_STRICT === $errno) {
+
+		}
+	}
+
+	if (E_STRICT === $errno ) {
+	}
+}