Update GetNonVirtualPropertyHookReadRule.php

staabm · staabm · commit 0239c902b088 · 2025-03-02T12:04:00.000+01:00
diff --git a/src/Rules/Properties/GetNonVirtualPropertyHookReadRule.php b/src/Rules/Properties/GetNonVirtualPropertyHookReadRule.php
@@ -76,6 +76,10 @@ public function processNode(Node $node, Scope $scope): array
 					continue;
 				}
 
+				if ($hook->body === null) {
+					continue;
+				}
+
 				$hasGetHook = true;
 				break;
 			}
@@ -93,10 +97,6 @@ public function processNode(Node $node, Scope $scope): array
 				continue;
 			}
 
-			if ($propertyReflection->isAbstract()->yes()) {
-				continue;
-			}
-
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Get hook for non-virtual property %s::$%s does not read its value.',
 				$classReflection->getDisplayName(),

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,10 @@ public function processNode(Node $node, Scope $scope): array`
`76`	`76`	`continue;`
`77`	`77`	`}`
`78`	`78`
	`79`	`+ if ($hook->body === null) {`
	`80`	`+ continue;`
	`81`	`+ }`
	`82`	`+`
`79`	`83`	`$hasGetHook = true;`
`80`	`84`	`break;`
`81`	`85`	`}`
`@@ -93,10 +97,6 @@ public function processNode(Node $node, Scope $scope): array`
`93`	`97`	`continue;`
`94`	`98`	`}`
`95`	`99`
`96`		`- if ($propertyReflection->isAbstract()->yes()) {`
`97`		`- continue;`
`98`		`- }`
`99`		`-`
`100`	`100`	`$errors[] = RuleErrorBuilder::message(sprintf(`
`101`	`101`	`'Get hook for non-virtual property %s::$%s does not read its value.',`
`102`	`102`	`$classReflection->getDisplayName(),`