enforce supported version bounds

Author: staabm

e2e/composer-min-open-end-version/test.php

@@ -1,6 +1,6 @@
 <?php
 
-\PHPStan\Testing\assertType('int<80100, max>', PHP_VERSION_ID);
-\PHPStan\Testing\assertType('int<8, max>', PHP_MAJOR_VERSION);
-\PHPStan\Testing\assertType('int<0, max>', PHP_MINOR_VERSION);
+\PHPStan\Testing\assertType('int<80100, 80499>', PHP_VERSION_ID);
+\PHPStan\Testing\assertType('8', PHP_MAJOR_VERSION);
+\PHPStan\Testing\assertType('int<1, 4>', PHP_MINOR_VERSION);
 \PHPStan\Testing\assertType('int<0, max>', PHP_RELEASE_VERSION);

e2e/composer-min-version/test.php

@@ -1,6 +1,6 @@
 <?php
 
-\PHPStan\Testing\assertType('int<80100, 90000>', PHP_VERSION_ID);
-\PHPStan\Testing\assertType('int<8, 9>', PHP_MAJOR_VERSION);
-\PHPStan\Testing\assertType('int<0, max>', PHP_MINOR_VERSION);
+\PHPStan\Testing\assertType('int<80100, 80499>', PHP_VERSION_ID);
+\PHPStan\Testing\assertType('8', PHP_MAJOR_VERSION);
+\PHPStan\Testing\assertType('int<1, 4>', PHP_MINOR_VERSION);
 \PHPStan\Testing\assertType('int<0, max>', PHP_RELEASE_VERSION);

src/Php/ComposerPhpVersionFactory.php

@@ -15,6 +15,8 @@
 use function is_file;
 use function is_int;
 use function is_string;
+use function max;
+use function min;
 use function sprintf;
 
 final class ComposerPhpVersionFactory
@@ -58,6 +60,9 @@ private function initVersions(): void
 			return;
 		}
 
+		$this->minVersion = new PhpVersion(PhpVersionFactory::MIN_PHP_VERSION);
+		$this->maxVersion = new PhpVersion(PhpVersionFactory::MAX_PHP_VERSION);
+
 		// fallback to composer.json based php-version constraint
 		$composerPhpVersion = $this->getComposerRequireVersion();
 		if ($composerPhpVersion === null) {
@@ -140,6 +145,9 @@ private function buildVersion(string $minVersion): ?PhpVersion
 		$patch = $matches[3] ?? 0;
 		$versionId = (int) sprintf('%d%02d%02d', $major, $minor, $patch);
 
+		$versionId = max($versionId, PhpVersionFactory::MIN_PHP_VERSION);
+		$versionId = min($versionId, PhpVersionFactory::MAX_PHP_VERSION);
+
 		return new PhpVersion($versionId);
 	}
 

src/Php/PhpVersionFactory.php

@@ -10,6 +10,9 @@
 final class PhpVersionFactory
 {
 
+	public const MIN_PHP_VERSION = 70100;
+	public const MAX_PHP_VERSION = 80499;
+
 	public function __construct(
 		private ?int $versionId,
 		private ?string $composerPhpVersion,
@@ -25,8 +28,8 @@ public function create(): PhpVersion
 		} elseif ($this->composerPhpVersion !== null) {
 			$parts = explode('.', $this->composerPhpVersion);
 			$tmp = (int) $parts[0] * 10000 + (int) ($parts[1] ?? 0) * 100 + (int) ($parts[2] ?? 0);
-			$tmp = max($tmp, 70100);
-			$versionId = min($tmp, 80499);
+			$tmp = max($tmp, self::MIN_PHP_VERSION);
+			$versionId = min($tmp, self::MAX_PHP_VERSION);
 			$source = PhpVersion::SOURCE_COMPOSER_PLATFORM_PHP;
 		} else {
 			$versionId = PHP_VERSION_ID;