fix missing errors

Author: schlndh

src/Rules/Functions/PrintfHelper.php

@@ -116,19 +116,16 @@ private function parsePlaceholders(string $specifiersPattern, string $format): a
 		$placeholders = array_filter($matches, static fn (array $match): bool => strlen($match['before']) % 2 === 0);
 
 		$result = [];
-		$positionToIdxMap = [];
 		$positionalPlaceholders = [];
-		$idx = $position = 0;
+		$idx = 0;
 
 		foreach ($placeholders as $placeholder) {
 			if (isset($placeholder['width']) && $placeholder['width'] !== '') {
-				$result[$idx] = ['strict-int' => 1];
-				$positionToIdxMap[$position++] = $idx++;
+				$result[$idx++] = ['strict-int' => 1];
 			}
 
 			if (isset($placeholder['precision']) && $placeholder['precision'] !== '') {
-				$result[$idx] = ['strict-int' => 1];
-				$positionToIdxMap[$position++] = $idx++;
+				$result[$idx++] = ['strict-int' => 1];
 			}
 
 			if (isset($placeholder['position']) && $placeholder['position'] !== '') {
@@ -137,8 +134,6 @@ private function parsePlaceholders(string $specifiersPattern, string $format): a
 				continue;
 			}
 
-			$position++;
-			$positionToIdxMap[$position] = $idx;
 			$result[$idx++][$this->getAcceptingTypeBySpecifier($placeholder['specifier'] ?? '')] = 1;
 		}
 
@@ -148,12 +143,7 @@ private function parsePlaceholders(string $specifiersPattern, string $format): a
 		);
 
 		foreach ($positionalPlaceholders as $placeholder) {
-			$idx = $positionToIdxMap[$placeholder['position']] ?? null;
-
-			if ($idx === null) {
-				continue;
-			}
-
+			$idx = $placeholder['position'] - 1;
 			$result[$idx][$this->getAcceptingTypeBySpecifier($placeholder['specifier'] ?? '')] = 1;
 		}
 

tests/PHPStan/Rules/Functions/PrintfParameterTypeRuleTest.php

@@ -84,6 +84,18 @@ public function test(): void
 				'Placeholder #1 of function printf expects int, string given',
 				26,
 			],
+			[
+				'Placeholder #1 of function printf expects float, PrintfParamTypes\\FooStringable given',
+				27,
+			],
+			[
+				'Placeholder #1 of function printf expects float, PrintfParamTypes\\FooStringable given',
+				28,
+			],
+			[
+				'Placeholder #3 of function printf expects float, PrintfParamTypes\\FooStringable given',
+				29,
+			],
 		]);
 	}