Trinary logic migration

DanielEScherzer · DanielEScherzer · commit 131caa620495 · 2025-08-28T23:43:19.000+03:00
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -183,4 +183,9 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -171,4 +171,9 @@ public function getAttributes(): array
 		return $this->reflection->getAttributes();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return $this->reflection->hasNoDiscardAttribute();
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -157,4 +157,10 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		// Align with the getAttributes() returning empty
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -149,4 +149,10 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		// Align with the getAttributes() returning empty
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -65,4 +65,11 @@ public function isPure(): TrinaryLogic;
 	 */
 	public function getAttributes(): array;
 
+	/**
+	 * Has the #[\NoDiscard] attribute - on PHP 8.5+ if the function's return
+	 * value is unused at runtime a warning is emitted, phpstan will emit the
+	 * warning during analysis and on older PHP versions too
+	 */
+	public function hasNoDiscardAttribute(): TrinaryLogic;
+
 }
diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -62,4 +62,11 @@ public function isPure(): TrinaryLogic;
 	 */
 	public function getAttributes(): array;
 
+	/**
+	 * Has the #[\NoDiscard] attribute - on PHP 8.5+ if the function's return
+	 * value is unused at runtime a warning is emitted, phpstan will emit the
+	 * warning during analysis and on older PHP versions too
+	 */
+	public function hasNoDiscardAttribute(): TrinaryLogic;
+
 }
diff --git a/src/Reflection/Native/NativeFunctionReflection.php b/src/Reflection/Native/NativeFunctionReflection.php
@@ -150,4 +150,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -227,4 +227,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -202,4 +202,9 @@ public function getAttributes(): array
 		return $this->nativeMethodReflection->getAttributes();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return $this->nativeMethodReflection->hasNoDiscardAttribute();
+	}
+
 }
diff --git a/src/Reflection/Php/EnumCasesMethodReflection.php b/src/Reflection/Php/EnumCasesMethodReflection.php
@@ -161,4 +161,9 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 }
diff --git a/src/Reflection/Php/ExitFunctionReflection.php b/src/Reflection/Php/ExitFunctionReflection.php
@@ -143,4 +143,9 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -330,4 +330,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -275,4 +275,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -520,4 +520,14 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		foreach ($this->attributes as $attrib) {
+			if ($attrib->getName() === 'NoDiscard') {
+				return TrinaryLogic::createYes();
+			}
+		}
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -229,4 +229,9 @@ public function getAttributes(): array
 		return $this->reflection->getAttributes();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return $this->reflection->hasNoDiscardAttribute();
+	}
+
 }
diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -228,4 +228,9 @@ public function getAttributes(): array
 		return $this->methods[0]->getAttributes();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->hasNoDiscardAttribute());
+	}
+
 }
diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -205,4 +205,9 @@ public function getAttributes(): array
 		return $this->methods[0]->getAttributes();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->hasNoDiscardAttribute());
+	}
+
 }
diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -173,4 +173,10 @@ public function getAttributes(): array
 		return [];
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		// Align with the getAttributes() returning empty
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Rules/Functions/CallToFunctionStatementWithNoDiscardRule.php b/src/Rules/Functions/CallToFunctionStatementWithNoDiscardRule.php
@@ -43,15 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$function = $this->reflectionProvider->getFunction($funcCall->name, $scope);
 
-		$attributes = $function->getAttributes();
-		$hasNoDiscard = false;
-		foreach ($attributes as $attrib) {
-			if ($attrib->getName() === 'NoDiscard') {
-				$hasNoDiscard = true;
-				break;
-			}
-		}
-		if (!$hasNoDiscard) {
+		if (!$function->hasNoDiscardAttribute()->yes()) {
 			return [];
 		}
 
diff --git a/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php b/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php
@@ -145,4 +145,9 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->methodReflection->hasSideEffects();
 	}
 
+	public function hasNoDiscardAttribute(): TrinaryLogic
+	{
+		return $this->methodReflection->hasNoDiscardAttribute();
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -183,4 +183,9 @@ public function getAttributes(): array`
`183`	`183`	`return [];`
`184`	`184`	`}`
`185`	`185`
	`186`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`187`	`+ {`
	`188`	`+ return TrinaryLogic::createNo();`
	`189`	`+ }`
	`190`	`+`
`186`	`191`	`}`
Original file line number	Diff line number	Diff line change
`@@ -171,4 +171,9 @@ public function getAttributes(): array`
`171`	`171`	`return $this->reflection->getAttributes();`
`172`	`172`	`}`
`173`	`173`
	`174`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`175`	`+ {`
	`176`	`+ return $this->reflection->hasNoDiscardAttribute();`
	`177`	`+ }`
	`178`	`+`
`174`	`179`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,4 +157,10 @@ public function getAttributes(): array`
`157`	`157`	`return [];`
`158`	`158`	`}`
`159`	`159`
	`160`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`161`	`+ {`
	`162`	`+ // Align with the getAttributes() returning empty`
	`163`	`+ return TrinaryLogic::createNo();`
	`164`	`+ }`
	`165`	`+`
`160`	`166`	`}`
Original file line number	Diff line number	Diff line change
`@@ -149,4 +149,10 @@ public function getAttributes(): array`
`149`	`149`	`return [];`
`150`	`150`	`}`
`151`	`151`
	`152`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`153`	`+ {`
	`154`	`+ // Align with the getAttributes() returning empty`
	`155`	`+ return TrinaryLogic::createNo();`
	`156`	`+ }`
	`157`	`+`
`152`	`158`	`}`
Original file line number	Diff line number	Diff line change
`@@ -150,4 +150,14 @@ public function getAttributes(): array`
`150`	`150`	`return $this->attributes;`
`151`	`151`	`}`
`152`	`152`
	`153`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`154`	`+ {`
	`155`	`+ foreach ($this->attributes as $attrib) {`
	`156`	`+ if ($attrib->getName() === 'NoDiscard') {`
	`157`	`+ return TrinaryLogic::createYes();`
	`158`	`+ }`
	`159`	`+ }`
	`160`	`+ return TrinaryLogic::createNo();`
	`161`	`+ }`
	`162`	`+`
`153`	`163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -227,4 +227,14 @@ public function getAttributes(): array`
`227`	`227`	`return $this->attributes;`
`228`	`228`	`}`
`229`	`229`
	`230`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`231`	`+ {`
	`232`	`+ foreach ($this->attributes as $attrib) {`
	`233`	`+ if ($attrib->getName() === 'NoDiscard') {`
	`234`	`+ return TrinaryLogic::createYes();`
	`235`	`+ }`
	`236`	`+ }`
	`237`	`+ return TrinaryLogic::createNo();`
	`238`	`+ }`
	`239`	`+`
`230`	`240`	`}`
Original file line number	Diff line number	Diff line change
`@@ -202,4 +202,9 @@ public function getAttributes(): array`
`202`	`202`	`return $this->nativeMethodReflection->getAttributes();`
`203`	`203`	`}`
`204`	`204`
	`205`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`206`	`+ {`
	`207`	`+ return $this->nativeMethodReflection->hasNoDiscardAttribute();`
	`208`	`+ }`
	`209`	`+`
`205`	`210`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,4 +161,9 @@ public function getAttributes(): array`
`161`	`161`	`return [];`
`162`	`162`	`}`
`163`	`163`
	`164`	`+ public function hasNoDiscardAttribute(): TrinaryLogic`
	`165`	`+ {`
	`166`	`+ return TrinaryLogic::createYes();`
	`167`	`+ }`
	`168`	`+`
`164`	`169`	`}`