Prevent reporting property.inInterface error when PHP version is 8.4 or later

Author: jakubtobiasz

src/Rules/Properties/PropertiesInInterfaceRule.php

@@ -13,6 +13,7 @@
  */
 final class PropertiesInInterfaceRule implements Rule
 {
+	private const PHP_8_4_VERSION_ID = 80400;
 
 	public function getNodeType(): string
 	{
@@ -25,6 +26,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (PHP_VERSION_ID >= self::PHP_8_4_VERSION_ID) {
+			return [];
+		}
+
 		return [
 			RuleErrorBuilder::message('Interfaces may not include properties.')
 				->nonIgnorable()

tests/PHPStan/Rules/Properties/PropertiesInInterfaceRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Properties;
 
+use PHPStan\Analyser\Error;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
@@ -10,6 +11,7 @@
  */
 class PropertiesInInterfaceRuleTest extends RuleTestCase
 {
+	private const PHP_8_4_VERSION_ID = 80400;
 
 	protected function getRule(): Rule
 	{
@@ -30,4 +32,36 @@ public function testRule(): void
 		]);
 	}
 
+	public function testIgnoringPropertyInInterfaceOnPHPBelow84(): void
+	{
+		if (PHP_VERSION_ID >= self::PHP_8_4_VERSION_ID) {
+			$this->markTestSkipped('Test is valid only on PHP 8.3 or earlier');
+		}
+
+		$errors = $this->gatherAnalyserErrors([__DIR__ . '/data/properties-in-interface-ignore-property-in-interface.php']);
+
+		/** @var array<Error> $propertyInInterfaceErrors */
+		$propertyInInterfaceErrors = array_filter($errors, static function (Error $error) {
+			return $error->getIdentifier() === 'property.inInterface';
+		});
+
+		$this->assertCount(1, $propertyInInterfaceErrors);
+		$this->assertFalse($propertyInInterfaceErrors[0]->canBeIgnored());
+	}
+
+	public function testIgnoringPropertyInInterfaceOnPHP84OrAbove(): void
+	{
+		if (PHP_VERSION_ID < self::PHP_8_4_VERSION_ID) {
+			$this->markTestSkipped('Test is valid only on PHP 8.4 or later');
+		}
+
+		$errors = $this->gatherAnalyserErrors([__DIR__ . '/data/properties-in-interface-ignore-property-in-interface.php']);
+
+		/** @var array<Error> $propertyInInterfaceErrors */
+		$propertyInInterfaceErrors = array_filter($errors, static function (Error $error) {
+			return $error->getIdentifier() === 'property.inInterface';
+		});
+
+		$this->assertCount(0, $propertyInInterfaceErrors);
+	}
 }

tests/PHPStan/Rules/Properties/data/properties-in-interface-ignore-property-in-interface.php

@@ -0,0 +1,8 @@
+<?php declare(strict_types=1);
+
+namespace PHPStan\Rules\Properties\data;
+
+interface HelloWorld
+{
+    public string $name;
+}