RuleTestCase - set shouldPolluteScopeWithLoopInitialAssignments to true which is PHPStan's default behaviour

Author: ondrejmirtes

src/Testing/RuleTestCase.php

@@ -206,7 +206,7 @@ public function gatherAnalyserErrors(array $files): array
 
 	protected function shouldPolluteScopeWithLoopInitialAssignments(): bool
 	{
-		return false;
+		return true;
 	}
 
 	protected function shouldPolluteScopeWithAlwaysIterableForeach(): bool

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -151,7 +151,7 @@ public function testStrictComparison(): void
 					335,
 				],
 				[
-					'Strict comparison using === between int<0, max> and \'string\' will always evaluate to false.',
+					'Strict comparison using === between int<1, max> and \'string\' will always evaluate to false.',
 					343,
 				],
 				[

tests/PHPStan/Rules/Properties/data/access-properties-after-isnull.php

@@ -33,22 +33,22 @@ public function doFoo($foo)
 		}
 
 		while (is_null($foo) && $foo->fooProperty) {
-
+			break;
 		}
 		while (is_null($foo) || $foo->fooProperty) {
-
+			break;
 		}
 		while (!is_null($foo) && $foo->fooProperty) {
-
+			break;
 		}
 		while (!is_null($foo) || $foo->fooProperty) {
-
+			break;
 		}
 		while (is_null($foo) || $foo->barProperty) {
-
+			break;
 		}
 		while (!is_null($foo) && $foo->barProperty) {
-
+			break;
 		}
 	}