hasSideEffects default true

Author: zonuexe

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -678,7 +678,7 @@ private function createMethod(
 			}
 
 			if ($this->signatureMapProvider->hasMethodMetadata($declaringClassName, $methodReflection->getName())) {
-				$hasSideEffects = TrinaryLogic::createFromBoolean($this->signatureMapProvider->getMethodMetadata($declaringClassName, $methodReflection->getName())['hasSideEffects'] ?? false);
+				$hasSideEffects = TrinaryLogic::createFromBoolean($this->signatureMapProvider->getMethodMetadata($declaringClassName, $methodReflection->getName())['hasSideEffects'] ?? true);
 			} else {
 				$hasSideEffects = TrinaryLogic::createMaybe();
 			}
@@ -842,7 +842,7 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 		$isPure = null;
 		foreach ($actualDeclaringClass->getAncestors() as $className => $ancestor) {
 			if ($this->signatureMapProvider->hasMethodMetadata($className, $methodReflection->getName())) {
-				$hasSideEffects = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName())['hasSideEffects'];
+				$hasSideEffects = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName())['hasSideEffects'] ?? true;
 				$isPure = !$hasSideEffects;
 
 				break;