Rename

Author: VincentLanglet

conf/config.neon

@@ -79,7 +79,7 @@ parameters:
 	reportStaticMethodSignatures: false
 	reportWrongPhpDocTypeInVarTag: false
 	reportAnyTypeWideningInVarTag: false
-	reportArrayKeyCast: false
+	allowFloatBoolNullAsArrayKey: true
 	reportPossiblyNonexistentGeneralArrayOffset: false
 	reportPossiblyNonexistentConstantArrayOffset: false
 	checkMissingOverrideMethodAttribute: false

conf/parametersSchema.neon

@@ -88,7 +88,7 @@ parametersSchema:
 	reportStaticMethodSignatures: bool()
 	reportWrongPhpDocTypeInVarTag: bool()
 	reportAnyTypeWideningInVarTag: bool()
-	reportArrayKeyCast: bool()
+	allowFloatBoolNullAsArrayKey: bool()
 	reportPossiblyNonexistentGeneralArrayOffset: bool()
 	reportPossiblyNonexistentConstantArrayOffset: bool()
 	checkMissingOverrideMethodAttribute: bool()

src/Rules/Arrays/AllowedArrayKeysTypes.php

@@ -22,14 +22,14 @@
 final class AllowedArrayKeysTypes
 {
 
-	public static function getType(?PhpVersion $phpVersion = null, bool $strict = false): Type
+	public static function getType(?PhpVersion $phpVersion = null, bool $allowFloatBoolNull = true): Type
 	{
 		$types = [
 			new IntegerType(),
 			new StringType(),
 		];
 
-		if (!$strict) {
+		if (!$allowFloatBoolNull) {
 			$types[] = new BooleanType();
 
 			if ($phpVersion === null || !$phpVersion->deprecatesImplicitlyFloatConversionToInt()) {

src/Rules/Arrays/InvalidKeyInArrayDimFetchRule.php

@@ -28,7 +28,7 @@ public function __construct(
 		#[AutowiredParameter]
 		private bool $reportMaybes,
 		#[AutowiredParameter]
-		private bool $reportArrayKeyCast,
+		private bool $allowFloatBoolNullAsArrayKey,
 	)
 	{
 	}
@@ -60,7 +60,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion, $this->reportArrayKeyCast);
+		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion, $this->allowFloatBoolNullAsArrayKey);
 		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->dim,

src/Rules/Arrays/InvalidKeyInArrayItemRule.php

@@ -26,7 +26,7 @@ public function __construct(
 		private RuleLevelHelper $ruleLevelHelper,
 		private PhpVersion $phpVersion,
 		#[AutowiredParameter]
-		private bool $reportArrayKeyCast,
+		private bool $allowFloatBoolNullAsArrayKey,
 	)
 	{
 	}
@@ -42,7 +42,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion, $this->reportArrayKeyCast);
+		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion, $this->allowFloatBoolNullAsArrayKey);
 		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->key,

tests/PHPStan/Rules/Arrays/InvalidKeyInArrayDimFetchRuleTest.php

@@ -15,7 +15,7 @@
 class InvalidKeyInArrayDimFetchRuleTest extends RuleTestCase
 {
 
-	private bool $reportCastedArrayKey = false;
+	private bool $allowFloatBoolNullAsArrayKey = true;
 
 	protected function getRule(): Rule
 	{
@@ -24,7 +24,7 @@ protected function getRule(): Rule
 			$ruleLevelHelper,
 			self::getContainer()->getByType(PhpVersion::class),
 			true,
-			$this->reportCastedArrayKey,
+			$this->allowFloatBoolNullAsArrayKey,
 		);
 	}
 
@@ -168,7 +168,7 @@ public function testBug12981(): void
 
 	public function testUnsetFalseKey(): void
 	{
-		$this->reportCastedArrayKey = true;
+		$this->allowFloatBoolNullAsArrayKey = false;
 
 		$this->analyse([__DIR__ . '/data/unset-false-key.php'], [
 			[

tests/PHPStan/Rules/Arrays/InvalidKeyInArrayItemRuleTest.php

@@ -15,7 +15,7 @@
 class InvalidKeyInArrayItemRuleTest extends RuleTestCase
 {
 
-	private bool $reportCastedArrayKey = false;
+	private bool $allowFloatBoolNullAsArrayKey = true;
 
 	private bool $checkExplicitMixed = false;
 
@@ -28,7 +28,7 @@ protected function getRule(): Rule
 		return new InvalidKeyInArrayItemRule(
 			$ruleLevelHelper,
 			self::getContainer()->getByType(PhpVersion::class),
-			$this->reportCastedArrayKey,
+			$this->allowFloatBoolNullAsArrayKey,
 		);
 	}
 
@@ -107,7 +107,7 @@ public function testInvalidMixedKey(): void
 
 	public function testInvalidKeyReportingCastedArrayKey(): void
 	{
-		$this->reportCastedArrayKey = true;
+		$this->allowFloatBoolNullAsArrayKey = false;
 
 		$this->analyse([__DIR__ . '/data/invalid-key-array-item.php'], [
 			[