Resolve #12999

Author: lpd-au

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -218,7 +218,7 @@ private function createProperty(
 					$types[] = $value;
 				}
 
-				return new PhpPropertyReflection($declaringClassReflection, null, null, TypeCombinator::union(...$types), $classReflection->getNativeReflection()->getProperty($propertyName), null, null, null, false, false, false, false, []);
+				return new PhpPropertyReflection($declaringClassReflection, null, null, TypeCombinator::union(...$types), $classReflection->getNativeReflection()->getProperty($propertyName), null, null, null, false, false, false, false, [], false);
 			}
 		}
 
@@ -227,6 +227,7 @@ private function createProperty(
 		$isDeprecated = $deprecation !== null;
 		$isInternal = false;
 		$isReadOnlyByPhpDoc = $classReflection->isImmutable();
+		$isFinalByPhpDoc = $classReflection->isFinal();
 		$isAllowedPrivateMutation = false;
 
 		if (
@@ -308,6 +309,7 @@ private function createProperty(
 			}
 			$isInternal = $resolvedPhpDoc->isInternal();
 			$isReadOnlyByPhpDoc = $isReadOnlyByPhpDoc || $resolvedPhpDoc->isReadOnly();
+			$isFinalByPhpDoc = $isFinalByPhpDoc || $resolvedPhpDoc->isFinal();
 			$isAllowedPrivateMutation = $resolvedPhpDoc->isAllowedPrivateMutation();
 		}
 
@@ -435,6 +437,7 @@ private function createProperty(
 			$isReadOnlyByPhpDoc,
 			$isAllowedPrivateMutation,
 			$this->attributeReflectionFactory->fromNativeReflection($propertyReflection->getAttributes(), InitializerExprContext::fromClass($declaringClassReflection->getName(), $declaringClassReflection->getFileName())),
+			$isFinalByPhpDoc,
 		);
 	}
 

src/Reflection/Php/PhpPropertyReflection.php

@@ -44,6 +44,7 @@ public function __construct(
 		private bool $isReadOnlyByPhpDoc,
 		private bool $isAllowedPrivateMutation,
 		private array $attributes,
+		private bool $isFinalByPhpDoc,
 	)
 	{
 	}
@@ -98,6 +99,11 @@ public function isReadOnlyByPhpDoc(): bool
 		return $this->isReadOnlyByPhpDoc;
 	}
 
+	public function isFinalByPhpDoc(): bool
+	{
+		return $this->isFinalByPhpDoc;
+	}
+
 	public function getReadableType(): Type
 	{
 		if ($this->type === null) {

src/Rules/Variables/UnsetRule.php

@@ -82,6 +82,7 @@ public function processNode(Node $node, Scope $scope): array
 					if (
 						!$propertyReflection->isPrivate()
 						&& !$propertyReflection->isFinal()->yes()
+						&& !$propertyReflection->isFinalByPhpDoc()
 						&& !$propertyReflection->getDeclaringClass()->isFinal()
 					) {
 						$errors[] = RuleErrorBuilder::message(

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -167,55 +167,55 @@ public function testUnsetHookedProperty(): void
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\NonFinalClass::$publicProperty because it might have hooks in a subclass.',
-				13,
+				14,
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\ContainerClass::$finalClass because it might have hooks in a subclass.',
-				83,
+				86,
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\ContainerClass::$nonFinalClass because it might have hooks in a subclass.',
-				87,
+				91,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\Foo::$iii property.',
-				89,
+				93,
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\ContainerClass::$foo because it might have hooks in a subclass.',
-				90,
+				94,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
-				92,
+				96,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
-				93,
+				97,
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\ContainerClass::$user because it might have hooks in a subclass.',
-				94,
+				98,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
-				96,
+				100,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
-				97,
+				101,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
-				98,
+				102,
 			],
 			[
 				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
-				99,
+				103,
 			],
 			[
 				'Cannot unset property UnsetHookedProperty\ContainerClass::$arrayOfUsers because it might have hooks in a subclass.',
-				100,
+				104,
 			],
 		]);
 	}

tests/PHPStan/Rules/Variables/data/unset-hooked-property.php

@@ -9,6 +9,7 @@ function doUnset(Foo $foo, User $user, NonFinalClass $nonFinalClass, FinalClass
 	unset($foo->ii);
 	unset($foo->iii);
 
+	unset($nonFinalClass->publicAnnotatedFinalProperty);
 	unset($nonFinalClass->publicFinalProperty);
 	unset($nonFinalClass->publicProperty);
 
@@ -49,6 +50,8 @@ class NonFinalClass {
 	private string $privateProperty;
 	public string $publicProperty;
 	final public string $publicFinalProperty;
+	/** @final */
+	public string $publicAnnotatedFinalProperty;
 
 	function doFoo() {
 		unset($this->privateProperty);
@@ -82,6 +85,7 @@ function dooNestedUnset(ContainerClass $containerClass) {
 	unset($containerClass->finalClass->publicProperty);
 	unset($containerClass->finalClass);
 
+	unset($containerClass->nonFinalClass->publicAnnotatedFinalProperty);
 	unset($containerClass->nonFinalClass->publicFinalProperty);
 	unset($containerClass->nonFinalClass->publicProperty);
 	unset($containerClass->nonFinalClass);