Skip to content

Commit 26ec4c3

Browse files
committed
simplify ConstantResolver
1 parent ae37f41 commit 26ec4c3

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/Analyser/ConstantResolver.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(
4545
private ReflectionProviderProvider $reflectionProviderProvider,
4646
private array $dynamicConstantNames,
4747
private int|array|null $phpVersion,
48-
private ?ComposerPhpVersionFactory $composerPhpVersionFactory,
48+
private ComposerPhpVersionFactory $composerPhpVersionFactory,
4949
)
5050
{
5151
}
@@ -370,10 +370,6 @@ private function getMinPhpVersion(): ?PhpVersion
370370
return new PhpVersion($this->phpVersion['min']);
371371
}
372372

373-
if ($this->composerPhpVersionFactory === null) {
374-
return null;
375-
}
376-
377373
return $this->composerPhpVersionFactory->getMinVersion();
378374
}
379375

@@ -391,10 +387,6 @@ private function getMaxPhpVersion(): ?PhpVersion
391387
return new PhpVersion($this->phpVersion['max']);
392388
}
393389

394-
if ($this->composerPhpVersionFactory === null) {
395-
return null;
396-
}
397-
398390
return $this->composerPhpVersionFactory->getMaxVersion();
399391
}
400392

src/DependencyInjection/ValidateIgnoredErrorsExtension.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use PHPStan\Command\IgnoredRegexValidator;
1313
use PHPStan\DependencyInjection\Type\OperatorTypeSpecifyingExtensionRegistryProvider;
1414
use PHPStan\File\FileExcluder;
15+
use PHPStan\Php\ComposerPhpVersionFactory;
1516
use PHPStan\Php\PhpVersion;
1617
use PHPStan\PhpDoc\DirectTypeNodeResolverExtensionRegistryProvider;
1718
use PHPStan\PhpDoc\TypeNodeResolver;
@@ -65,7 +66,8 @@ public function loadConfiguration(): void
6566
$reflectionProviderProvider = new DirectReflectionProviderProvider($reflectionProvider);
6667
ReflectionProviderStaticAccessor::registerInstance($reflectionProvider);
6768
PhpVersionStaticAccessor::registerInstance(new PhpVersion(PHP_VERSION_ID));
68-
$constantResolver = new ConstantResolver($reflectionProviderProvider, [], null, null);
69+
$composerPhpVersionFactory = new ComposerPhpVersionFactory($builder->parameters['composerAutoloaderProjectPaths']);
70+
$constantResolver = new ConstantResolver($reflectionProviderProvider, [], null, $composerPhpVersionFactory);
6971

7072
$phpDocParserConfig = new ParserConfig([]);
7173
$ignoredRegexValidator = new IgnoredRegexValidator(

0 commit comments

Comments
 (0)